Skip to content

Remove Key.get() and Entity.reload() - #522

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:remove-key-get
Jan 8, 2015
Merged

Remove Key.get() and Entity.reload()#522
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:remove-key-get

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

Has #521 as diffbase.

Removed Entity.reload() because it relied on the existence of Key.get(). Replacing it would have required another cyclic import.

See #490 RE: removing Entity.reload().

Fixes#517.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling 9600c11 on dhermes:remove-key-get into 77cfe10 on GoogleCloudPlatform:master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 1b152ee on dhermes:remove-key-get into * on GoogleCloudPlatform:master*.

@tseaver

Copy link
Copy Markdown
Contributor

Hmm, doesn't affect demo? (/me looks) I guess not. LGTM

Removed Entity.reload() because it relied on the existence
of Key.get(). Replacing it would have required import
gcloud.datastore.get in entity.py, which would have again
been a cyclic import.
With an eye on removing the Entity class (see googleapis#490),
removing Entity.reload() is not such a big deal.
Fixesgoogleapis#517.
@coveralls

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 6d351a5 on dhermes:remove-key-get into * on GoogleCloudPlatform:master*.

@dhermes

Copy link
Copy Markdown
ContributorAuthor

I just ran python -m gcloud.datastore.demo and it worked just fine. Thanks

dhermes added a commit that referenced this pull request Jan 8, 2015
Remove Key.get() and Entity.reload()
@dhermes
dhermes merged commit 0525530 into googleapis:masterJan 8, 2015
@dhermes
dhermes deleted the remove-key-get branch January 8, 2015 23:15
@dhermesdhermes mentioned this pull request Jan 14, 2015
8 tasks
@dhermesdhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015
parthea pushed a commit that referenced this pull request Aug 15, 2023
Source-Link: https://togithub.com/googleapis/synthtool/commit/d0f51a0c2a9a6bcca86911eabea9e484baadf64b
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:240b5bcc2bafd450912d2da2be15e62bc6de2cf839823ae4bf94d4f392b451dc
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
- [ ] Regenerate this pull request now.
PiperOrigin-RevId: 451250442
Source-Link: googleapis/googleapis@cca5e81
Source-Link: googleapis/googleapis-gen@0b219da
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMGIyMTlkYTE2MWE4YmRjYzNjNmY3YjJlZmNkODIxMDUxODJhMzBjYSJ9
parthea added a commit that referenced this pull request Sep 22, 2023
* chore: enable warnings as errors in docs build
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
parthea pushed a commit that referenced this pull request Oct 21, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
* fix: Add async context manager return types
chore: Mock return_value should not populate oneof message fields
chore: Support snippet generation for services that only support REST transport
chore: Update gapic-generator-python to v1.11.0
PiperOrigin-RevId: 545430278
Source-Link: googleapis/googleapis@601b532
Source-Link: googleapis/googleapis-gen@b3f18d0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjNmMThkMGY2NTYwYTg1NTAyMmZkMDU4ODY1ZTc2MjA0NzlkN2FmOSJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Aug 21, 2025
* fix(deps): allow protobuf 3.19.5
* explicitly exclude protobuf 4.21.0
parthea added a commit that referenced this pull request Sep 16, 2025
* fix(deps): allow protobuf 3.19.5
* explicitly exclude protobuf 4.21.0
parthea pushed a commit that referenced this pull request Sep 18, 2025
…522)
Source-Link: googleapis/synthtool@6b4d5a6
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f792ee1320e03eda2d13a5281a2989f7ed8a9e50b73ef6da97fac7e1e850b149
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 22, 2025
Source-Link: googleapis/synthtool@ca87909
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6162c384d685c5fe22521d3f37f6fc732bf99a085f6d47b677dbcae97fc21392
parthea added a commit that referenced this pull request Nov 24, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
Fixes#518
We'll need to identify the longer term fix here, but this will unblock current CI failures
parthea added a commit that referenced this pull request Nov 24, 2025
* deps: Pin jinja2 version to fix CI
* deps: Pin werkzeug version in sub-repo
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
parthea added a commit that referenced this pull request Nov 25, 2025
* deps: Pin jinja2 version to fix CI
* deps: Pin werkzeug version in sub-repo
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Mar 2, 2026
🤖 I have created a release \*beep\* \*boop\*
---
## [2.9.0](https://www.github.com/googleapis/python-pubsub/compare/v2.8.0...v2.9.0) (2021-11-10)
### Features
* add context manager support in client ([#516](https://www.github.com/googleapis/python-pubsub/issues/516)) ([51eae67](https://www.github.com/googleapis/python-pubsub/commit/51eae67c47e2ce7d2f7620209e98df4a129801b5))
* add support for Python 3.10 ([#518](https://www.github.com/googleapis/python-pubsub/issues/518)) ([bb25d75](https://www.github.com/googleapis/python-pubsub/commit/bb25d755d70ba19e69d8a281be65f13eb994967d))
### Bug Fixes
* add 'dict' annotation type to 'request' ([b72522a](https://www.github.com/googleapis/python-pubsub/commit/b72522a4617c4b2773fb6a5a631038791aa08300))
* **deps:** drop packaging dependency ([290b9c5](https://www.github.com/googleapis/python-pubsub/commit/290b9c5615eaa03674b773a27b756483abd76195))
* **deps:** require google-api-core >= 1.28.0 ([290b9c5](https://www.github.com/googleapis/python-pubsub/commit/290b9c5615eaa03674b773a27b756483abd76195))
* improper types in pagers generation ([2ad639d](https://www.github.com/googleapis/python-pubsub/commit/2ad639d6370c7a085498595d7bd0d7eaadfff3c1))
### Documentation
* add type annotations to codebase ([#509](https://www.github.com/googleapis/python-pubsub/issues/509)) ([093cabf](https://www.github.com/googleapis/python-pubsub/commit/093cabff9f0464b1dfaa8f373b6fffbc439518de))
* list oneofs in docstring ([290b9c5](https://www.github.com/googleapis/python-pubsub/commit/290b9c5615eaa03674b773a27b756483abd76195))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Mar 6, 2026
* feat: add determinism level for javascript UDFs
* Add enum-like class for routine determinism level
parthea pushed a commit that referenced this pull request Mar 9, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Mar 9, 2026
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [google-cloud-spanner](https://togithub.com/googleapis/python-spanner) | `==3.7.0` -> `==3.8.0` | [![age](https://badges.renovateapi.com/packages/pypi/google-cloud-spanner/3.8.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/google-cloud-spanner/3.8.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/google-cloud-spanner/3.8.0/compatibility-slim/3.7.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/google-cloud-spanner/3.8.0/confidence-slim/3.7.0)](https://docs.renovatebot.com/merge-confidence/) |
---
### Release Notes
<details>
<summary>googleapis/python-spanner</summary>
### [`v3.8.0`](https://togithub.com/googleapis/python-spanner/blob/master/CHANGELOG.md#&#8203;380-httpswwwgithubcomgoogleapispython-spannercomparev370v380-2021-08-15)
[Compare Source](https://togithub.com/googleapis/python-spanner/compare/v3.7.0...v3.8.0)
##### Features
- use DML batches in `executemany()` method ([#&#8203;412](https://www.togithub.com/googleapis/python-spanner/issues/412)) ([cbb4ee3](https://www.github.com/googleapis/python-spanner/commit/cbb4ee3eca9ac878b4f3cd78cfcfe8fc1acb86f9))
##### Bug Fixes
- **samples:** batch_update() results processing error ([#&#8203;484](https://www.togithub.com/googleapis/python-spanner/issues/484)) ([bdd5f8b](https://www.github.com/googleapis/python-spanner/commit/bdd5f8b201d1b442837d4fca1d631fe171e276b9))
</details>
---
### Configuration
📅 **Schedule**: At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.
---
This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-spanner).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastoreIssues related to the Datastore API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove cyclic imports or just stop worrying and love the bomb

3 participants

@dhermes@coveralls@tseaver