Skip to content

Allow get() to take a single key (in addition to a list) - #521

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:allow-get-single-key
Jan 8, 2015
Merged

Allow get() to take a single key (in addition to a list)#521
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:allow-get-single-key

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

Has #520 as diffbase.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage remained the same when pulling 923302a on dhermes:allow-get-single-key into 77cfe10 on GoogleCloudPlatform:master.

@tseaver

Copy link
Copy Markdown
Contributor

I've avoided collections.Iterable in the past, because it matches str / unicode. Maybe we don't care about that here.

@tseaver

Copy link
Copy Markdown
Contributor

Other than that, LGTM

@dhermes
dhermesforce-pushed the allow-get-single-key branch from 923302a to 184cfb9CompareJanuary 8, 2015 23:06
@dhermes

Copy link
Copy Markdown
ContributorAuthor

My take is that if the iterable does not contain Keys then it will fail at the point of keys[0].dataset_id.

For example I accidentally left [key] in Test_get_function._miss_helper

ifuse_list:
key= [key]
results=self._callFUT([key], connection=connection)

and got an error like

Traceback (most recent call last):
File "<stdin>", line 1, in <module>
AttributeError: 'list' object has no attribute 'dataset_id'

@coveralls

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling 184cfb9 on dhermes:allow-get-single-key into * on GoogleCloudPlatform:master*.

dhermes added a commit that referenced this pull request Jan 8, 2015
Allow get() to take a single key (in addition to a list)
@dhermes
dhermes merged commit 12c6afd into googleapis:masterJan 8, 2015
@dhermes
dhermes deleted the allow-get-single-key branch January 8, 2015 23:10
@dhermesdhermes mentioned this pull request Jan 14, 2015
8 tasks
@dhermesdhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015
parthea pushed a commit that referenced this pull request Aug 15, 2023
Source-Link: https://togithub.com/googleapis/synthtool/commit/30bd01b4ab78bf1b2a425816e15b3e7e090993dd
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9bc5fa3b62b091f60614c08a7fb4fd1d3e1678e326f34dd66ce1eefb5dc3267b
parthea pushed a commit that referenced this pull request Sep 22, 2023
* feat: add support for new Dataproc features
PiperOrigin-RevId: 510421528
Source-Link: googleapis/googleapis@5a395e4
Source-Link: googleapis/googleapis-gen@54e9de1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTRlOWRlMWYxM2RiZTBjNmJlZjViYzZlN2EyYTRlZGJkNTg4YmQxYiJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Oct 21, 2023
Source-Link: googleapis/synthtool@6ed3a83
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3abfa0f1886adaf0b83f07cb117b24a639ea1cb9cffe56d43280b977033563eb
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit that referenced this pull request Oct 21, 2023
* feat: Add support for python 3.11
chore: Update gapic-generator-python to v1.8.0
PiperOrigin-RevId: 500768693
Source-Link: googleapis/googleapis@190b612
Source-Link: googleapis/googleapis-gen@7bf29a4
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* require proto-plus 1.22.2 for python 3.11; workaround docs issue
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
Source-Link: googleapis/synthtool@5f2a608
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
Source-Link: googleapis/synthtool@cb96037
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2d816f26f728ac8b24248741e7d4c461c09764ef9f7be3684d557c9632e46dbd
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Aug 21, 2025
parthea pushed a commit that referenced this pull request Sep 16, 2025
parthea pushed a commit that referenced this pull request Nov 24, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Nov 24, 2025
…utionStats (#521)
* feat: Allow users to explicitly configure universe domain
chore: Update gapic-generator-python to v1.14.0
PiperOrigin-RevId: 603108274
Source-Link: googleapis/googleapis@3d83e36
Source-Link: googleapis/googleapis-gen@baf5e9b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYmFmNWU5YmJiMTRhNzY4YjJiNGM5ZWFlOWZlYjc4ZjE4ZjE3NTdmYSJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* fix: Resolve AttributeError 'Credentials' object has no attribute 'universe_domain'
fix: Add google-auth as a direct dependency
fix: Add staticmethod decorator to methods added in v1.14.0
chore: Update gapic-generator-python to v1.14.1
PiperOrigin-RevId: 603728206
Source-Link: googleapis/googleapis@9063da8
Source-Link: googleapis/googleapis-gen@891c67d
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODkxYzY3ZDBhODU1YjA4MDg1ZWIzMDFkYWJiMTQwNjRlZjRiMmM2ZCJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* fix(diregapic): s/bazel/bazelisk/ in DIREGAPIC build GitHub action
PiperOrigin-RevId: 604714585
Source-Link: googleapis/googleapis@e4dce13
Source-Link: googleapis/googleapis-gen@4036f78
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDAzNmY3ODMwNWM1YzJhYWI4MGZmOTE5NjBiM2EzZDk4M2ZmNGIwMyJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* fix(deps): Require `google-api-core>=1.34.1`
fix: Resolve issue with missing import for certain enums in `**/types/…`
PiperOrigin-RevId: 607041732
Source-Link: googleapis/googleapis@b453267
Source-Link: googleapis/googleapis-gen@cd79641
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2Q3OTY0MTZmMGY1NGNiMjJiMmM0NGZiMmQ0ODY5NjBlNjkzYTM0NiJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* fix(deps): Exclude google-auth 2.24.0 and 2.25.0
chore: Update gapic-generator-python to v1.14.4
PiperOrigin-RevId: 611561820
Source-Link: googleapis/googleapis@87ef1fe
Source-Link: googleapis/googleapis-gen@1973161
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTk3MzE2MTM3NTk0YWFmYWQ5NGRlYTMxMjI2NTI4ZmJjYzM5MzEwYyJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* feat: Add include_recaptcha_script for as a new action in firewall policies
PiperOrigin-RevId: 612851792
Source-Link: googleapis/googleapis@49ea2c0
Source-Link: googleapis/googleapis-gen@460fdcb
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDYwZmRjYmJiZTAwZjM1YjFjNTkxYjFmM2VmMGM3N2ViZDNjZTI3NyJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* fix coverage
* fix(deps): require google-auth >= 2.14.1
* feat: add new types ExplainOptions, ExplainMetrics, PlanSummary, ExecutionStats
feat: add ExplainOptions field to RunQueryRequest
feat: add ExplainMetrics field to RunQueryResponse
feat: add ExplainOptions field to RunAggregationQueryRequest
feat: add ExplainMetrics field to RunAggregationQueryResponse
PiperOrigin-RevId: 615158168
Source-Link: googleapis/googleapis@4d535ac
Source-Link: googleapis/googleapis-gen@02e272d
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDJlMjcyZGVkNTM4YjBmOTc4MzJiZmFkNDdkZWNiYzNkYzY1YTg5YSJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
* chore: Update gapic-generator-python to v1.18.5
PiperOrigin-RevId: 661268868
Source-Link: googleapis/googleapis@f7d214c
Source-Link: googleapis/googleapis-gen@79a8411
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzlhODQxMWJiZGIyNWE5ODNmYTNhYWU4YzBlMTQzMjdkZjEyOWY5NCJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Nov 24, 2025
* chore: remove googleapis/firestore-dpe from codeowners
* 🦉 Updates from OwlBot
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
)
Source-Link: googleapis/synthtool@7804ade
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:eede5672562a32821444a8e803fb984a6f61f2237ea3de229d2de24453f4ae7d
parthea pushed a commit that referenced this pull request Nov 24, 2025
…#521)
* style: upgrade black to latest version, use black default line length
* Upgrade to the latest version of black.
* Stop passing "--line-length" argument to black, to use default, like
other Google API libraries.
* Add some errors for flake8 to ignore, consistent with other Google API
Libraries.
parthea pushed a commit that referenced this pull request Nov 25, 2025
)
Source-Link: googleapis/synthtool@7804ade
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:eede5672562a32821444a8e803fb984a6f61f2237ea3de229d2de24453f4ae7d
parthea pushed a commit that referenced this pull request Nov 26, 2025
parthea pushed a commit that referenced this pull request Mar 6, 2026
parthea pushed a commit that referenced this pull request Mar 6, 2026
…on (#521)
* feat: BASELINE for DB API standard data types
* feat: implementation of PEP-0249 types
* chore: reverting "dummy" changes
* fix: cleanup
* chore: refactor
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastoreIssues related to the Datastore API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dhermes@coveralls@tseaver