Making regression3 pass by dhermes · Pull Request #756 · googleapis/google-cloud-python

dhermes · 2015-03-24T20:56:21Z

Uses latest release of oauth2client which incorporates Fixing JSON key service account assertions in Python3. oauth2client#126
Pulling from HEAD in httplib2 until Update __init__.py jcgregorio/httplib2#291 and Added unit test for #291 jcgregorio/httplib2#296 are incorporated
Updating bytes/unicode handling, mostly as in Ensuring response from httplib2 is treated as str in Python 2 and bytes in Python3 #724
Updating storage.batch._unpack_batch_response to straddle Py2/Py3. The email native str dependency is tricky there.
Added some more tests to cover unicode/bytes branching in library code
Updated regression for storage to explicitly use binary when str is insufficient in Py3

NOTE: As in googleapis/oauth2client#126, using %s for a Py2 and Py3 codebase caused us issues in _unpack_batch_response

Fixgoogleapis/oauth2client#125 was pushed in 1.4.7 release.

- Incorporates changes from googleapis#724. - Also requires httplib2 from HEAD since the bytes/unicode header issues have not been released on PyPI yet.

coveralls · 2015-03-24T23:20:40Z

Coverage remained the same at 100.0% when pulling 1b94f9f on dhermes:oauth2client-use-master into 3b04fdb on GoogleCloudPlatform:master.

dhermes · 2015-03-25T22:38:03Z

@tseaver PTAL

Sign in to view

- Adding test for branch miss in credentials._get_signed_query_params - Making storage.batch._unpack_batch_response work correctly in Python2 and Python3 (parser expects str in both) NOTE: Yet again %s caused issues between Py2 and Py3 (as in the PR googleapis#126 in oauth2client).

coveralls · 2015-03-27T15:43:43Z

Coverage remained the same at 100.0% when pulling fdb1d23 on dhermes:oauth2client-use-master into d34a15e on GoogleCloudPlatform:master.

tseaver · 2015-03-27T16:54:33Z

LGTM, module adding the comment to _unpack_batch_response.

dhermes · 2015-03-27T17:31:08Z

@tseaver I made a new commit from my phone. PTAL and then I'll merge if Travis passes.

coveralls · 2015-03-27T17:32:56Z

Coverage remained the same at 100.0% when pulling 73bb5bb on dhermes:oauth2client-use-master into d34a15e on GoogleCloudPlatform:master.

tseaver · 2015-03-27T17:34:44Z

LGTM

Making regression3 pass

dhermes · 2015-03-27T17:37:28Z

@tseaver should we add regression3 to .travis.yaml now that it passes?

tseaver · 2015-03-27T17:41:31Z

SGTM

* docs: Fix formatting of request arg in docstring chore: Update gapic-generator-python to v1.9.1 PiperOrigin-RevId: 518604533 Source-Link: googleapis/googleapis@8a085ae Source-Link: googleapis/googleapis-gen@b2ab4b0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

#760) Fix for #756. Under certain circumstances, flattened, repeated fields could be duplicated during request construction.

* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Daniel Sanche <sanche@google.com>

…p/templates/python_library/.kokoro (#756) Source-Link: googleapis/synthtool@d0f51a0 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:240b5bcc2bafd450912d2da2be15e62bc6de2cf839823ae4bf94d4f392b451dc Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…756) Source-Link: googleapis/synthtool@8e55b32 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c6c965a4bf40c19011b11f87dbc801a66d3a23fbc6704102be064ef31c51f1c3 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

dhermes added 2 commits March 24, 2015 13:50

Removing dependency on development checkout of oauth2client.
6cec5de
Fixgoogleapis/oauth2client#125 was pushed in 1.4.7 release.

Making regression3 pass by using bytes / unicode correctly.
11904c3
- Incorporates changes from googleapis#724. - Also requires httplib2 from HEAD since the bytes/unicode header issues have not been released on PyPI yet.

dhermes added the api: storage Issues related to the Cloud Storage API. label Mar 24, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 24, 2015

dhermes mentioned this pull request Mar 24, 2015
Ensuring response from httplib2 is treated as str in Python 2 and bytes in Python3 #724
Closed

dhermes mentioned this pull request Mar 25, 2015
Using correct format of exceptions from JSON based APIs. #762
Merged

tseaver reviewed Mar 26, 2015
View reviewed changes

Comment threadgcloud/storage/batch.py Outdated
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view
This comment was marked as spam.
Sign in to view

dhermes force-pushed the oauth2client-use-master branch from 1b94f9f to fdb1d23Compare March 27, 2015 15:41

Adding comment about bytes coercion in _unpack_batch_response.
73bb5bb

dhermes added a commit that referenced this pull request Mar 27, 2015
Merge pull request#756from dhermes/oauth2client-use-master
4785201
Making regression3 pass

dhermes merged commit 4785201 into googleapis:masterMar 27, 2015

dhermes deleted the oauth2client-use-master branch March 28, 2015 08:17

dhermes mentioned this pull request Apr 9, 2015
Upgrading version to 0.5.0. #813
Merged

parthea pushed a commit that referenced this pull request Nov 24, 2025
fix: remove duplicate assignment of certain flattened, repeated fields (
dc2597f
#760) Fix for #756. Under certain circumstances, flattened, repeated fields could be duplicated during request construction.

parthea added a commit that referenced this pull request Nov 24, 2025
chore: add custom sync repo settings (#756)
47bb517

parthea pushed a commit that referenced this pull request Nov 26, 2025
chore: release 1.30.2 (#756)
e46043d
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Mar 9, 2026
chore(deps): update dependency pyparsing to v3.2.5 (#756)
a996309

Uh oh!

Conversation

dhermes commented Mar 24, 2015

Uh oh!

coveralls commented Mar 24, 2015

Uh oh!

dhermes commented Mar 25, 2015

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Mar 27, 2015

Uh oh!

tseaver commented Mar 27, 2015

Uh oh!

dhermes commented Mar 27, 2015

Uh oh!

coveralls commented Mar 27, 2015

Uh oh!

tseaver commented Mar 27, 2015

Uh oh!

dhermes commented Mar 27, 2015

Uh oh!

tseaver commented Mar 27, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants