Skip to content

Remove properties= from Blob and Bucket constructors - #760

Merged
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:remove-properties-from-constructor
Mar 28, 2015
Merged

Remove properties= from Blob and Bucket constructors#760
dhermes merged 2 commits into
googleapis:masterfrom
dhermes:remove-properties-from-constructor

Conversation

@dhermes

@dhermesdhermes commented Mar 25, 2015

Copy link
Copy Markdown
Contributor

NOTE: Has #759 as a diffbase.

This is an implementation detail intended to make internal code have an easier time constructing entities, but never had a story for end-users.

The only real changes are effectively:

- yield Bucket(properties=item, connection=self._ctor_connection)+ name = item.get('name')+ bucket = Bucket(name, connection=self._ctor_connection)+ bucket._properties = item+ yield bucket

For test conveniences, I've allowed _makeOne() to delegate the properties= keyword in the way it used to be used in the actual constructors.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 25, 2015
@dhermesdhermes added the api: storage Issues related to the Cloud Storage API. label Mar 25, 2015
@dhermes
dhermesforce-pushed the remove-properties-from-constructor branch from 7ed8baa to 9cd15a6CompareMarch 25, 2015 22:35
@coveralls

coveralls commented Mar 25, 2015

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 9cd15a6 on dhermes:remove-properties-from-constructor into d34a15e on GoogleCloudPlatform:master.

@coveralls

coveralls commented Mar 25, 2015

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 9cd15a6 on dhermes:remove-properties-from-constructor into d34a15e on GoogleCloudPlatform:master.

@tseaver

tseaver commented Mar 26, 2015

Copy link
Copy Markdown
Contributor

Changes relative to #759 LGTM.

@dhermes
dhermesforce-pushed the remove-properties-from-constructor branch from 9cd15a6 to 44e5b74CompareMarch 28, 2015 18:01
@coveralls

coveralls commented Mar 28, 2015

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 44e5b74 on dhermes:remove-properties-from-constructor into 3906245 on GoogleCloudPlatform:master.

@dhermes

dhermes commented Mar 28, 2015

Copy link
Copy Markdown
ContributorAuthor

@tseaver I peeled off the last two commits to separate from #759. Let me know if you're not cool with the merge.

dhermes added a commit that referenced this pull request Mar 28, 2015
@dhermes
Merge pull request#760from dhermes/remove-properties-from-constructor
622d994
Remove properties= from Blob and Bucket constructors
@dhermes
dhermes merged commit 622d994 into googleapis:masterMar 28, 2015
@dhermes
dhermes deleted the remove-properties-from-constructor branch March 28, 2015 18:04
@dhermesdhermes mentioned this pull request Mar 28, 2015
Closed
@dhermesdhermes mentioned this pull request Apr 9, 2015
Merged
parthea added a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot@parthea
feat: Update Compute Engine API to revision 20221224 (#760) (#381)
03c9f20
* docs: Add documentation for enums
fix: Add context manager return types
chore: Update gapic-generator-python to v1.8.1
PiperOrigin-RevId: 503210727
Source-Link: googleapis/googleapis@a391fd1
Source-Link: googleapis/googleapis-gen@0080f83
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDA4MGY4MzBkZWMzN2MzMzg0MTU3MDgyYmNlMjc5ZTM3MDc5ZWE1OCJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* feat: Update Compute Engine API to revision 20221224 (#760)
Source-Link: googleapis/googleapis@17d5613
Source-Link: googleapis/googleapis-gen@42cd552
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDJjZDU1MmZhNWJlOTViZTVjZTUxMzZiYTkzZTgzMzg4Yjc1OTFkOCJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* work around docs issue
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Aug 21, 2025
@yirutang
feat: add client side lib id with lib version (#760)
59776e2
* .
* .
* .
* .
* .
* .
parthea pushed a commit that referenced this pull request Sep 16, 2025
@yirutang@parthea
feat: add client side lib id with lib version (#760)
4caff59
* .
* .
* .
* .
* .
* .
parthea pushed a commit that referenced this pull request Nov 22, 2025
@shweta345
chore(samples): Fixed a typo in the readme (#760)
f1342ee
parthea pushed a commit that referenced this pull request Nov 24, 2025
@software-dov
fix: remove duplicate assignment of certain flattened, repeated fields (
dc2597f
#760)
Fix for #756. Under certain circumstances, flattened, repeated fields
could be duplicated during request construction.
parthea pushed a commit that referenced this pull request Nov 24, 2025
@release-please
chore: release 0.40.6 (#762)
4ab1632
🤖 I have created a release \*beep\* \*boop\* ---
### [0.40.6](https://www.github.com/googleapis/gapic-generator-python/compare/v0.40.5...v0.40.6) (2021-02-02)
### Bug Fixes
* remove duplicate assignment of certain flattened, repeated fields ([#760](https://www.github.com/googleapis/gapic-generator-python/issues/760)) ([cdbc221](https://www.github.com/googleapis/gapic-generator-python/commit/cdbc22130a176e733c529f60a6b8b1d224e82e89))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Nov 24, 2025
@gcf-owl-bot
chore: remove pinned Sphinx version [autoapprove] (#760)
78f534c
Source-Link: googleapis/synthtool@909573c
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ddf4551385d566771dc713090feb7b4c1164fb8a698fe52bbe7670b24236565b
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 25, 2025
@gcf-owl-bot
chore: remove pinned Sphinx version [autoapprove] (#760)
1e88f28
Source-Link: googleapis/synthtool@909573c
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ddf4551385d566771dc713090feb7b4c1164fb8a698fe52bbe7670b24236565b
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
@tseaver
fix: enforce constraints during unit tests (#760)
d70edbb
Drop explicit pin / constraint on 'urllib3': specific 'requests'
versions have very narrow pins, and ours is only likely to create
conflicts.
Bump the 'requests' lower bound to '2.20.0', the lowest version for
which our tests pass once constraints are being checked.
Closes#759
parthea pushed a commit that referenced this pull request Mar 2, 2026
@acocuzzo
fix: set stream_ack_deadline to max_duration_per_lease_extension or 6…
80cd984
…0 s, set ack_deadline to min_duration_per_lease_extension or 10 s (#760)
parthea pushed a commit that referenced this pull request Mar 6, 2026
@release-please
chore: release 2.21.0 (#760)
4919152
🤖 I have created a release \*beep\* \*boop\*
---
## [2.21.0](https://www.github.com/googleapis/python-bigquery/compare/v2.20.0...v2.21.0) (2021-07-14)
### Features
* add always_use_jwt_access ([#714](https://www.github.com/googleapis/python-bigquery/issues/714)) ([92fbd4a](https://www.github.com/googleapis/python-bigquery/commit/92fbd4ade37e0be49dc278080ef73c83eafeea18))
* add max_results parameter to some of the QueryJob methods ([#698](https://www.github.com/googleapis/python-bigquery/issues/698)) ([2a9618f](https://www.github.com/googleapis/python-bigquery/commit/2a9618f4daaa4a014161e1a2f7376844eec9e8da))
* add support for decimal target types ([#735](https://www.github.com/googleapis/python-bigquery/issues/735)) ([7d2d3e9](https://www.github.com/googleapis/python-bigquery/commit/7d2d3e906a9eb161911a198fb925ad79de5df934))
* add support for table snapshots ([#740](https://www.github.com/googleapis/python-bigquery/issues/740)) ([ba86b2a](https://www.github.com/googleapis/python-bigquery/commit/ba86b2a6300ae5a9f3c803beeb42bda4c522e34c))
* enable unsetting policy tags on schema fields ([#703](https://www.github.com/googleapis/python-bigquery/issues/703)) ([18bb443](https://www.github.com/googleapis/python-bigquery/commit/18bb443c7acd0a75dcb57d9aebe38b2d734ff8c7))
* make it easier to disable best-effort deduplication with streaming inserts ([#734](https://www.github.com/googleapis/python-bigquery/issues/734)) ([1246da8](https://www.github.com/googleapis/python-bigquery/commit/1246da86b78b03ca1aa2c45ec71649e294cfb2f1))
* Support passing struct data to the DB API ([#718](https://www.github.com/googleapis/python-bigquery/issues/718)) ([38b3ef9](https://www.github.com/googleapis/python-bigquery/commit/38b3ef96c3dedc139b84f0ff06885141ae7ce78c))
### Bug Fixes
* inserting non-finite floats with insert_rows() ([#728](https://www.github.com/googleapis/python-bigquery/issues/728)) ([d047419](https://www.github.com/googleapis/python-bigquery/commit/d047419879e807e123296da2eee89a5253050166))
* use pandas function to check for NaN ([#750](https://www.github.com/googleapis/python-bigquery/issues/750)) ([67bc5fb](https://www.github.com/googleapis/python-bigquery/commit/67bc5fbd306be7cdffd216f3791d4024acfa95b3))
### Documentation
* add docs for all enums in module ([#745](https://www.github.com/googleapis/python-bigquery/issues/745)) ([145944f](https://www.github.com/googleapis/python-bigquery/commit/145944f24fedc4d739687399a8309f9d51d43dfd))
* omit mention of Python 2.7 in `CONTRIBUTING.rst` ([#706](https://www.github.com/googleapis/python-bigquery/issues/706)) ([27d6839](https://www.github.com/googleapis/python-bigquery/commit/27d6839ee8a40909e4199cfa0da8b6b64705b2e9))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Mar 6, 2026
@renovate-bot
chore(deps): update actions/setup-python action to v3 (#760)
9d25a80
parthea pushed a commit that referenced this pull request Mar 9, 2026
@renovate-bot
chore(deps): update dependency google-cloud-spanner to v3.58.0 (#760)
bc3a2b6
parthea pushed a commit that referenced this pull request Mar 9, 2026
@cojenco
chore: add internal benchmarking script (#760)
e00904e
* chore: add internal benchmarking script and readme
* archive benchwrapper to subdirectory
* blacken lint
* fix typo
* update script with preconditions and upload from disk
* download to file
* update multiprocessing and readme
* clean up
* update benchmarking script
* update checksumming options and default num processes
* replace tempfile package usage
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: storageIssues related to the Cloud Storage API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhermes@coveralls@tseaver@googlebot