Skip to content

Translate: Add client options to translate_v2. - #8737

Merged
busunkim96 merged 6 commits into
googleapis:masterfrom
busunkim96:translate-client-options
Jul 30, 2019
Merged

Translate: Add client options to translate_v2.#8737
busunkim96 merged 6 commits into
googleapis:masterfrom
busunkim96:translate-client-options

Conversation

@busunkim96

Copy link
Copy Markdown
Contributor

Towards #8475.

@busunkim96busunkim96 added the api: translation Issues related to the Cloud Translation API API. label Jul 23, 2019
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 23, 2019
Comment threadtranslate/google/cloud/translate_v2/_http.py Outdated
Comment threadtranslate/google/cloud/translate_v2/_http.py Outdated
@busunkim96
busunkim96force-pushed the translate-client-options branch from 3be2555 to f5cb28cCompareJuly 29, 2019 17:24
@tseavertseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2019

@tseavertseaver left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failure seemed to be a race: google-cloud-core 1.0.3 wasn't yet available on PyPI. The docs job installs it from PyPI, rather than the local checkout.

@busunkim96
busunkim96 merged commit 3979e8b into googleapis:masterJul 30, 2019
parthea pushed a commit that referenced this pull request Oct 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: translationIssues related to the Cloud Translation API API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@busunkim96@tseaver@googlebot@yoshi-kokoro