Uh oh!
There was an error while loading. Please reload this page.
Core: Make build_api_url an instance method. - #8747
Merged
Merged
Conversation
tseaver
approved these changes
Jul 24, 2019
tseaver
commented
Jul 24, 2019
Contributor
@busunkim96 This is a case where we'd actually like to test the change against the affected API libraries ( |
ContributorAuthor
BigQuery unit test failures seem to be unrelated: |
tseaver
commented
Jul 25, 2019
Contributor
The BigQuery failure is likely due to a new version of a dependency ( The Logging failure is a known flakiness in systest teardown, #8676. |
tseaver
commented
Jul 26, 2019
Contributor
@busunkim96 Do you want to back out d4f53bf from the PR before merging? |
tseaver
commented
Jul 26, 2019
Contributor
Also, a rebase would likely fix the BigQuery failure, if you'd like to do that first. |
busunkim96force-pushed
the
cloud-core-update
branch
from
July 26, 2019 17:15
d4f53bf to
75a4b66Compareparthea pushed a commit
that referenced
this pull request
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #8737.