Skip to content

Removing cover-min-percentage=100 from coveralls. - #940

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:fix-939
Jun 23, 2015
Merged

Removing cover-min-percentage=100 from coveralls.#940
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:fix-939

Conversation

@dhermes

Copy link
Copy Markdown
Contributor

Fixes#939.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 23, 2015
@tseaver

Copy link
Copy Markdown
Contributor

We dropped running tox -e cover in the "main" tests in Travis, which would block the tox -e coveralls bit (in after_success). Is a drop in coverage still going to show up as a failed check?

@dhermes

Copy link
Copy Markdown
ContributorAuthor

@tseaver The coverage/coveralls check will fail but the continuous-integration/travis-ci/pr check will not. Is that sufficient?

@dhermes

Copy link
Copy Markdown
ContributorAuthor

I can add a fake PR after this for us to test. Something silly like

if False:
print 'I will never happen' # Maybe though because False is just a variable

@tseaver

Copy link
Copy Markdown
Contributor

If we're sure that PRs will show up with failed checks, then go ahead. I don't really see the value-add of coveralls is over just running tox -e cover within Travis, but if we're going to use it, we should definitely let it work as expected.

@dhermes

Copy link
Copy Markdown
ContributorAuthor

We use coveralls for the fancy badge on the front page. cover is in the default list, so running tox locally will run tox -e cover.

I'm taking your "go ahead" as an LGTM. Happy to rollback if I misunderstood.

dhermes added a commit that referenced this pull request Jun 23, 2015
Removing cover-min-percentage=100 from coveralls.
@dhermes
dhermes merged commit 8622fa0 into googleapis:masterJun 23, 2015
@dhermes
dhermes deleted the fix-939 branch June 23, 2015 20:15
@dhermesdhermes mentioned this pull request Jun 23, 2015
@dhermesdhermes mentioned this pull request Jul 10, 2015
parthea pushed a commit that referenced this pull request Nov 24, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
Source-Link: googleapis/synthtool@71a7297
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e8dcfd7cbfd8beac3a3ff8d3f3185287ea0625d859168cc80faccfc9a7a00455
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 25, 2025
Source-Link: googleapis/synthtool@71a7297
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e8dcfd7cbfd8beac3a3ff8d3f3185287ea0625d859168cc80faccfc9a7a00455
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
parthea added a commit that referenced this pull request Mar 2, 2026
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Mar 6, 2026
…940)
* chore: Reduce duplicated code betweem tests/unit and tests/unit/job
* reuse parent make_client
parthea added a commit that referenced this pull request Mar 6, 2026
Towards googleapis/librarian#2460
---------
Co-authored-by: ohmayr <omairn@google.com>
parthea pushed a commit that referenced this pull request Mar 9, 2026
This reverts commit 4862a9c34fcd9524f31312227a2ccf5e376f39fa.
parthea pushed a commit that referenced this pull request Mar 9, 2026
* changes
* tests
* Update client.py
* Update test_client.py
* Update connection.py
* setting feature false
* changes
* set LAR true
* Update connection.py
* Update client.py
* changes
* changes
---------
Co-authored-by: surbhigarg92 <surbhigarg.92@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dhermes@tseaver@googlebot