Skip to content

Fake commit. - #942

Closed
dhermes wants to merge 3 commits into
googleapis:masterfrom
dhermes:fake-commit-test-coveralls
Closed

Fake commit.#942
dhermes wants to merge 3 commits into
googleapis:masterfrom
dhermes:fake-commit-test-coveralls

Conversation

@dhermes

@dhermesdhermes commented Jun 23, 2015

Copy link
Copy Markdown
Contributor

@tseaver This is to make sure #940 works.

@dhermesdhermes added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 23, 2015
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 23, 2015
@dhermes
dhermesforce-pushed the fake-commit-test-coveralls branch from f4e5d16 to a66b43dCompareJune 23, 2015 20:21
@tseaver

tseaver commented Jun 23, 2015

Copy link
Copy Markdown
Contributor

LOL: failed lint:

************* Module gcloud.datastore.query
C: 83, 0: Unnecessary parens after 'print' keyword (superfluous-parens)

@dhermes

dhermes commented Jun 23, 2015

Copy link
Copy Markdown
ContributorAuthor

@tseaver Yep and I also discovered tox -e docs failed. The nice thing is that pylint won't complain about that if from __future__ import print_function is in the module.

@dhermes

dhermes commented Jun 23, 2015

Copy link
Copy Markdown
ContributorAuthor

@tseaver We can address that in #943. This commit is not intended to be merged.

More importantly, 99.99% did not result in a failure from coveralls.io

I'll dig in now and see what I can do.

@dhermes

dhermes commented Jun 23, 2015

Copy link
Copy Markdown
ContributorAuthor

@tseaver I signed in to coveralls.io and changed the settings, let's hope this handles it

screen_shot_014

@dhermes

dhermes commented Jun 23, 2015

Copy link
Copy Markdown
ContributorAuthor

I should mention that both the "COVERAGE THRESHOLD FOR FAILURE" and "COVERAGE DECREASE THRESHOLD FOR FAILURE" boxes were empty (which I take to mean unset) before I updated the values.

@dhermes

dhermes commented Jun 23, 2015

Copy link
Copy Markdown
ContributorAuthor

@tseaver I'm closing out. It looks like tweaking the settings did the trick. Feel free to re-open if you don't think this resolves it.

@dhermesdhermes closed this Jun 23, 2015
@dhermes
dhermes deleted the fake-commit-test-coveralls branch June 23, 2015 20:52
parthea pushed a commit that referenced this pull request Aug 21, 2025
@release-please
chore(main): release 2.32.0 (#942)
ea06ce3
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 16, 2025
@release-please@parthea
chore(main): release 2.32.0 (#942)
dfe2fbb
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
@busunkim96
fix: fix syntax for Deprecationwarning (#942)
7b53dcc
parthea pushed a commit that referenced this pull request Mar 2, 2026
@gcf-owl-bot
chore: store artifacts in placer (#942)
47fbd96
Source-Link: googleapis/synthtool@cb96037
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2d816f26f728ac8b24248741e7d4c461c09764ef9f7be3684d557c9632e46dbd
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Mar 6, 2026
Jim Fulton
chore: update system tests and samples to use and @google.com email a…
609dcb8
…ddress (#942)
* chore: update system tests and samples to use and @google.com email address
* Add group prefix
* fixed access entry some more
parthea pushed a commit that referenced this pull request Mar 9, 2026
@release-please
chore(main): release 3.34.0 (#942)
6785982
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.do not mergeIndicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dhermes@tseaver@googlebot