Skip to content

tests(asset): normalize VPCSC configuration in systests - #9614

Merged
tseaver merged 5 commits into
googleapis:masterfrom
tseaver:9580-asset-normalize-spcsc-config
Nov 11, 2019
Merged

tests(asset): normalize VPCSC configuration in systests#9614
tseaver merged 5 commits into
googleapis:masterfrom
tseaver:9580-asset-normalize-spcsc-config

Conversation

@tseaver

@tseavertseaver commented Nov 6, 2019

Copy link
Copy Markdown
Contributor

Toward #9580.

@tseavertseaver added testing api: cloudasset Issues related to the Cloud Asset Inventory API. labels Nov 6, 2019
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 6, 2019
@tseavertseaver mentioned this pull request Nov 6, 2019
Closed
10 tasks
@tseavertseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 6, 2019
@tseaver

tseaver commented Nov 6, 2019

Copy link
Copy Markdown
ContributorAuthor

I tagged with "do not merge" because I believe we should refactor all these un-idiomatic tests along the lines of the changes in #9618.

busunkim96
busunkim96 reviewed Nov 6, 2019
View reviewed changes
Comment threadasset/tests/system/test_vpcsc.py
@tseaver
tests(asset): do not set VPCSC env vars via nox.
ffa95c4
@tseaver
tests(asset): all these tests must run inside VPCSC
7881b50
- Move 'skip_unless_inside_vpcsc' to class scope.
- Drop never-reached branch for outside in '_do_test'.
- Don't swallow unexpected exceptions inside '_is_rejected.
@tseaver
test: remove unused var.
681037a
@tseaver
refactor: use one func per testcase
fb232d8
@tseavertseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 11, 2019
@tseaver

tseaver commented Nov 11, 2019

Copy link
Copy Markdown
ContributorAuthor

@busunkim96 I've removed the "do not merge" label after refactoring the VPCSC systests to be in line with #9618.

@tseaver
tseaver merged commit d08b210 into googleapis:masterNov 11, 2019
@tseaver
tseaver deleted the 9580-asset-normalize-spcsc-config branch November 11, 2019 22:32
@yoshi-automationyoshi-automation mentioned this pull request Jan 29, 2020
Merged
parthea pushed a commit that referenced this pull request Oct 21, 2023
@tseaver
tests(asset): normalize VPCSC configuration in systests (#9614)
3a076bb
Toward #9580.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@busunkim96busunkim96busunkim96 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: cloudassetIssues related to the Cloud Asset Inventory API.cla: yesThis human has signed the Contributor License Agreement.testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tseaver@busunkim96@googlebot