Skip to content

tests(trace): normalize VPCSC configuration in systests - #9618

Merged
tseaver merged 4 commits into
googleapis:masterfrom
tseaver:9580-trace-normalize-vpcsc-config
Nov 11, 2019
Merged

tests(trace): normalize VPCSC configuration in systests#9618
tseaver merged 4 commits into
googleapis:masterfrom
tseaver:9580-trace-normalize-vpcsc-config

Conversation

@tseaver

@tseavertseaver commented Nov 6, 2019

Copy link
Copy Markdown
Contributor

Toward #9580.

@tseaver
tests(trace): do not set VPCSC env vars via nox
e353d5a
@tseaver
tests(trace): normalize VPCSC configuration in systests
fd8f85c
- Skip based on 'vpcsc_config.skip_unless_inside_vpcsc'.
- Refactor VPCSC tests into one function per case, w/ expected exceptions.
- Invoke client methods directly using 'vpcsc_config' to decode env vars.
@tseavertseaver added testing api: cloudtrace Issues related to the Cloud Trace API. labels Nov 6, 2019
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 6, 2019
This was referenced Nov 6, 2019
Closed
Merged
Merged
Merged
busunkim96
busunkim96 approved these changes Nov 7, 2019
View reviewed changes
Comment threadtrace/tests/system/gapic/v2/test_system_trace_service_v2_vpcsc.py Outdated
Comment threadtrace/tests/system/gapic/v2/test_system_trace_service_v2_vpcsc.py Outdated
Comment threadtrace/tests/system/gapic/v1/test_system_trace_service_v1_vpcsc.py Outdated
@busunkim96busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2019
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2019
@tseaver
tseaver merged commit ef309fc into googleapis:masterNov 11, 2019
@tseaver
tseaver deleted the 9580-trace-normalize-vpcsc-config branch November 11, 2019 22:11
@yoshi-automationyoshi-automation mentioned this pull request Jan 29, 2020
Merged
parthea pushed a commit that referenced this pull request Oct 22, 2023
@tseaver
tests(trace): normalize VPCSC configuration in systests (#9618)
7bdc256
Toward #9580.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@busunkim96busunkim96busunkim96 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: cloudtraceIssues related to the Cloud Trace API.cla: yesThis human has signed the Contributor License Agreement.testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver@busunkim96@googlebot@yoshi-kokoro