This repository was archived by the owner on May 8, 2026. It is now read-only.

fix: Filters should be serializable - #397

Merged

igorbernstein2 merged 7 commits into

googleapis:masterfrom

dmitry-fa:filters-serialize

Sep 22, 2020

dmitry-fa commented Aug 28, 2020

Contributor

Fixes#385

fix: Filters should be serializable

b78063f

google-claBot added the cla: yes label

codecovBot commented Aug 28, 2020•
edited
Loading

Codecov Report

Merging #397 into master will increase coverage by 0.34%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## master #397 +/- ##
============================================
+ Coverage 80.24% 80.59% +0.34% - Complexity 1102 1115 +13 
============================================
Files 105 105 Lines 6815 6921 +106 Branches 364 369 +5 ============================================
+ Hits 5469 5578 +109 + Misses 1148 1145 -3 
Partials 198 198

Impacted Files	Coverage Δ	Complexity Δ
.../google/cloud/bigtable/data/v2/models/Filters.java	`81.72% <100.00%> (+6.72%)`	`16.00 <0.00> (ø)`
...e/cloud/bigtable/data/v2/BigtableDataSettings.java	`63.63% <0.00%> (-4.11%)`	`7.00% <0.00%> (ø%)`
...ble/data/v2/stub/EnhancedBigtableStubSettings.java	`96.80% <0.00%> (-0.44%)`	`22.00% <0.00%> (+1.00%)`	⬇️
.../google/cloud/bigtable/data/v2/models/RowCell.java	`100.00% <0.00%> (ø)`	`4.00% <0.00%> (+1.00%)`
...gle/cloud/bigtable/data/v2/BigtableDataClient.java	`94.02% <0.00%> (ø)`	`39.00% <0.00%> (ø%)`
...loud/bigtable/data/v2/internal/RefreshChannel.java
...d/bigtable/data/v2/stub/BigtableChannelPrimer.java	`83.09% <0.00%> (ø)`	`8.00% <0.00%> (?%)`
...ud/bigtable/data/v2/stub/EnhancedBigtableStub.java	`96.05% <0.00%> (+0.31%)`	`24.00% <0.00%> (+3.00%)`
...d/bigtable/data/v2/stub/metrics/MetricsTracer.java	`81.01% <0.00%> (+2.53%)`	`15.00% <0.00%> (+1.00%)`
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6e70a9...2683ee7. Read the comment docs.

dmitry-fa requested a review from igorbernstein2

August 28, 2020 10:44

product-auto-labelBot added the api: bigtable label

kolea2 reviewed

View reviewed changes

proto-google-cloud-bigtable-v2/src/main/java/com/google/bigtable/v2/RowFilterOrBuilder.java Outdated

igorbernstein2 suggested changes

View reviewed changes

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/models/FiltersTest.java Outdated

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/models/FiltersTest.java Outdated

proto-google-cloud-bigtable-v2/src/main/java/com/google/bigtable/v2/RowFilter.java Outdated

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/Filters.java Outdated

dmitry-fa added 3 commits

September 1, 2020 18:48

rollback changes to generated files

b3723f2

customize serialization of builders

2208adb

customize serialization of builders

94ca9ec

igorbernstein2 reviewed

View reviewed changes

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/models/FiltersTest.java

igorbernstein2 reviewed

View reviewed changes

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/models/FiltersTest.java Outdated

igorbernstein2 reviewed

View reviewed changes

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/models/FiltersTest.java Outdated

igorbernstein2 reviewed

View reviewed changes

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/models/FiltersTest.java Outdated

igorbernstein2 reviewed

View reviewed changes

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/models/FiltersTest.java

dmitry-fa added 3 commits

September 2, 2020 14:47

customize serialization of builders

9ce579f

check serialization of non-filter instances

e63841e

test for spawned filters

2683ee7

dmitry-fa requested a review from a team

September 18, 2020 08:59

igorbernstein2 approved these changes

View reviewed changes

igorbernstein2 left a comment

Contributor

lgtm

igorbernstein2 merged commit 57edfde into googleapis:master

gcf-merge-on-greenBot pushed a commit that referenced this pull request

chore: release 1.16.0 (#444)

f33c674

🤖 I have created a release \*beep\* \*boop\* ---
## [1.16.0](https://www.github.com/googleapis/java-bigtable/compare/v1.15.0...v1.16.0) (2020-10-06)
### Features
* add keepalive changes in java client library ([#409](https://www.github.com/googleapis/java-bigtable/issues/409)) ([edbcde1](https://www.github.com/googleapis/java-bigtable/commit/edbcde1a5b22317319803cb57401252aac6d580d))
* include User agent ([#404](https://www.github.com/googleapis/java-bigtable/issues/404)) ([0cd71b5](https://www.github.com/googleapis/java-bigtable/commit/0cd71b59305cd7a336c223faff68402a8bee4639))
* Ability to extend UserAgent string (via gax upgrade)
### Bug Fixes
* **test:** Clean up tests ([#439](https://www.github.com/googleapis/java-bigtable/issues/439)) ([c5c881b](https://www.github.com/googleapis/java-bigtable/commit/c5c881bb956860a393c2a7f34d0d790a23d270af))
* Add documentation to bulkReadRows that each batch will process t… ([#410](https://www.github.com/googleapis/java-bigtable/issues/410)) ([71dc8e3](https://www.github.com/googleapis/java-bigtable/commit/71dc8e3419fbb49d48bb7a3fd984d24e24661c81))
* Filters should be serializable ([#397](https://www.github.com/googleapis/java-bigtable/issues/397)) ([57edfde](https://www.github.com/googleapis/java-bigtable/commit/57edfde5eace28d50ec777e14589c9747616f0a8))
* RowCells are not actually serializeable ([#407](https://www.github.com/googleapis/java-bigtable/issues/407)) ([39e17cc](https://www.github.com/googleapis/java-bigtable/commit/39e17cc17c438f2d665875f9ff2b2cdf984e37b7))
* Fix race condition in Batcher.close() (via gax upgrade)
### Dependencies
* update dependency com.google.cloud:google-cloud-conformance-tests to v0.0.12 ([#415](https://www.github.com/googleapis/java-bigtable/issues/415)) ([7b3713a](https://www.github.com/googleapis/java-bigtable/commit/7b3713a8935b2f0b1ca57d189e9e0363506b28a1))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.10.0 ([#428](https://www.github.com/googleapis/java-bigtable/issues/428)) ([373032e](https://www.github.com/googleapis/java-bigtable/commit/373032e93b838cbc0ccab7dc45cd61b3b973542a))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.10.1 ([#443](https://www.github.com/googleapis/java-bigtable/issues/443)) ([939fefa](https://www.github.com/googleapis/java-bigtable/commit/939fefa819d09885489d9faeedadc74ee2b0e1b9))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.9.1 ([#427](https://www.github.com/googleapis/java-bigtable/issues/427)) ([5175e28](https://www.github.com/googleapis/java-bigtable/commit/5175e28f5ce69f6fb3ed14131c1cfd26dbc47bb9))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please).

ad548 pushed a commit to ad548/java-bigtable that referenced this pull request

chore: release 1.16.0 (googleapis#444)

36b482e

🤖 I have created a release \*beep\* \*boop\* ---
## [1.16.0](https://www.github.com/googleapis/java-bigtable/compare/v1.15.0...v1.16.0) (2020-10-06)
### Features
* add keepalive changes in java client library ([googleapis#409](https://www.github.com/googleapis/java-bigtable/issues/409)) ([edbcde1](https://www.github.com/googleapis/java-bigtable/commit/edbcde1a5b22317319803cb57401252aac6d580d))
* include User agent ([googleapis#404](https://www.github.com/googleapis/java-bigtable/issues/404)) ([0cd71b5](https://www.github.com/googleapis/java-bigtable/commit/0cd71b59305cd7a336c223faff68402a8bee4639))
* Ability to extend UserAgent string (via gax upgrade)
### Bug Fixes
* **test:** Clean up tests ([googleapis#439](https://www.github.com/googleapis/java-bigtable/issues/439)) ([c5c881b](https://www.github.com/googleapis/java-bigtable/commit/c5c881bb956860a393c2a7f34d0d790a23d270af))
* Add documentation to bulkReadRows that each batch will process t… ([googleapis#410](https://www.github.com/googleapis/java-bigtable/issues/410)) ([71dc8e3](https://www.github.com/googleapis/java-bigtable/commit/71dc8e3419fbb49d48bb7a3fd984d24e24661c81))
* Filters should be serializable ([googleapis#397](https://www.github.com/googleapis/java-bigtable/issues/397)) ([57edfde](https://www.github.com/googleapis/java-bigtable/commit/57edfde5eace28d50ec777e14589c9747616f0a8))
* RowCells are not actually serializeable ([googleapis#407](https://www.github.com/googleapis/java-bigtable/issues/407)) ([39e17cc](https://www.github.com/googleapis/java-bigtable/commit/39e17cc17c438f2d665875f9ff2b2cdf984e37b7))
* Fix race condition in Batcher.close() (via gax upgrade)
### Dependencies
* update dependency com.google.cloud:google-cloud-conformance-tests to v0.0.12 ([googleapis#415](https://www.github.com/googleapis/java-bigtable/issues/415)) ([7b3713a](https://www.github.com/googleapis/java-bigtable/commit/7b3713a8935b2f0b1ca57d189e9e0363506b28a1))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.10.0 ([googleapis#428](https://www.github.com/googleapis/java-bigtable/issues/428)) ([373032e](https://www.github.com/googleapis/java-bigtable/commit/373032e93b838cbc0ccab7dc45cd61b3b973542a))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.10.1 ([googleapis#443](https://www.github.com/googleapis/java-bigtable/issues/443)) ([939fefa](https://www.github.com/googleapis/java-bigtable/commit/939fefa819d09885489d9faeedadc74ee2b0e1b9))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.9.1 ([googleapis#427](https://www.github.com/googleapis/java-bigtable/issues/427)) ([5175e28](https://www.github.com/googleapis/java-bigtable/commit/5175e28f5ce69f6fb3ed14131c1cfd26dbc47bb9))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please).

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtablecla: yes