Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

fix: Add documentation to bulkReadRows that each batch will process t… - #410

Merged
igorbernstein2 merged 3 commits into
googleapis:masterfrom
dmitry-fa:bulkReadRows
Sep 14, 2020
Merged

fix: Add documentation to bulkReadRows that each batch will process t…#410
igorbernstein2 merged 3 commits into
googleapis:masterfrom
dmitry-fa:bulkReadRows

Conversation

@dmitry-fa

Copy link
Copy Markdown
Contributor

Fixes#386

@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Sep 8, 2020
@codecov

codecovBot commented Sep 8, 2020

Copy link
Copy Markdown

Codecov Report

Merging #410 into master will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #410 +/- ##
============================================
+ Coverage 80.24% 80.42% +0.17% - Complexity 1102 1114 +12 
============================================
Files 105 105 Lines 6815 6900 +85 Branches 364 369 +5 ============================================
+ Hits 5469 5549 +80 - Misses 1148 1152 +4 - Partials 198 199 +1 
Impacted FilesCoverage ΔComplexity Δ
...ud/bigtable/admin/v2/BigtableTableAdminClient.java72.16% <ø> (ø)35.00 <0.00> (ø)
...gle/cloud/bigtable/data/v2/BigtableDataClient.java94.02% <ø> (ø)39.00 <0.00> (ø)
...e/cloud/bigtable/data/v2/BigtableDataSettings.java63.63% <0.00%> (-4.11%)7.00% <0.00%> (ø%)
...ble/data/v2/stub/EnhancedBigtableStubSettings.java96.80% <0.00%> (-0.44%)22.00% <0.00%> (+1.00%)⬇️
.../google/cloud/bigtable/data/v2/models/RowCell.java100.00% <0.00%> (ø)4.00% <0.00%> (+1.00%)
...loud/bigtable/data/v2/internal/RefreshChannel.java
...d/bigtable/data/v2/stub/BigtableChannelPrimer.java83.09% <0.00%> (ø)8.00% <0.00%> (?%)
...ud/bigtable/data/v2/stub/EnhancedBigtableStub.java96.05% <0.00%> (+0.31%)24.00% <0.00%> (+3.00%)
...d/bigtable/data/v2/stub/metrics/MetricsTracer.java81.01% <0.00%> (+2.53%)15.00% <0.00%> (+1.00%)
...ata/v2/stub/readrows/FilterMarkerRowsCallable.java96.77% <0.00%> (+12.90%)2.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6e70a9...8c9a077. Read the comment docs.

@product-auto-labelproduct-auto-labelBot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Sep 9, 2020

@igorbernstein2igorbernstein2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@igorbernstein2
igorbernstein2 merged commit 71dc8e3 into googleapis:masterSep 14, 2020
gcf-merge-on-greenBot pushed a commit that referenced this pull request Oct 6, 2020
🤖 I have created a release \*beep\* \*boop\* ---
## [1.16.0](https://www.github.com/googleapis/java-bigtable/compare/v1.15.0...v1.16.0) (2020-10-06)
### Features
* add keepalive changes in java client library ([#409](https://www.github.com/googleapis/java-bigtable/issues/409)) ([edbcde1](https://www.github.com/googleapis/java-bigtable/commit/edbcde1a5b22317319803cb57401252aac6d580d))
* include User agent ([#404](https://www.github.com/googleapis/java-bigtable/issues/404)) ([0cd71b5](https://www.github.com/googleapis/java-bigtable/commit/0cd71b59305cd7a336c223faff68402a8bee4639))
* Ability to extend UserAgent string (via gax upgrade)
### Bug Fixes
* **test:** Clean up tests ([#439](https://www.github.com/googleapis/java-bigtable/issues/439)) ([c5c881b](https://www.github.com/googleapis/java-bigtable/commit/c5c881bb956860a393c2a7f34d0d790a23d270af))
* Add documentation to bulkReadRows that each batch will process t… ([#410](https://www.github.com/googleapis/java-bigtable/issues/410)) ([71dc8e3](https://www.github.com/googleapis/java-bigtable/commit/71dc8e3419fbb49d48bb7a3fd984d24e24661c81))
* Filters should be serializable ([#397](https://www.github.com/googleapis/java-bigtable/issues/397)) ([57edfde](https://www.github.com/googleapis/java-bigtable/commit/57edfde5eace28d50ec777e14589c9747616f0a8))
* RowCells are not actually serializeable ([#407](https://www.github.com/googleapis/java-bigtable/issues/407)) ([39e17cc](https://www.github.com/googleapis/java-bigtable/commit/39e17cc17c438f2d665875f9ff2b2cdf984e37b7))
* Fix race condition in Batcher.close() (via gax upgrade)
### Dependencies
* update dependency com.google.cloud:google-cloud-conformance-tests to v0.0.12 ([#415](https://www.github.com/googleapis/java-bigtable/issues/415)) ([7b3713a](https://www.github.com/googleapis/java-bigtable/commit/7b3713a8935b2f0b1ca57d189e9e0363506b28a1))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.10.0 ([#428](https://www.github.com/googleapis/java-bigtable/issues/428)) ([373032e](https://www.github.com/googleapis/java-bigtable/commit/373032e93b838cbc0ccab7dc45cd61b3b973542a))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.10.1 ([#443](https://www.github.com/googleapis/java-bigtable/issues/443)) ([939fefa](https://www.github.com/googleapis/java-bigtable/commit/939fefa819d09885489d9faeedadc74ee2b0e1b9))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.9.1 ([#427](https://www.github.com/googleapis/java-bigtable/issues/427)) ([5175e28](https://www.github.com/googleapis/java-bigtable/commit/5175e28f5ce69f6fb3ed14131c1cfd26dbc47bb9))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please).
ad548 pushed a commit to ad548/java-bigtable that referenced this pull request Mar 13, 2021
🤖 I have created a release \*beep\* \*boop\* ---
## [1.16.0](https://www.github.com/googleapis/java-bigtable/compare/v1.15.0...v1.16.0) (2020-10-06)
### Features
* add keepalive changes in java client library ([googleapis#409](https://www.github.com/googleapis/java-bigtable/issues/409)) ([edbcde1](https://www.github.com/googleapis/java-bigtable/commit/edbcde1a5b22317319803cb57401252aac6d580d))
* include User agent ([googleapis#404](https://www.github.com/googleapis/java-bigtable/issues/404)) ([0cd71b5](https://www.github.com/googleapis/java-bigtable/commit/0cd71b59305cd7a336c223faff68402a8bee4639))
* Ability to extend UserAgent string (via gax upgrade)
### Bug Fixes
* **test:** Clean up tests ([googleapis#439](https://www.github.com/googleapis/java-bigtable/issues/439)) ([c5c881b](https://www.github.com/googleapis/java-bigtable/commit/c5c881bb956860a393c2a7f34d0d790a23d270af))
* Add documentation to bulkReadRows that each batch will process t… ([googleapis#410](https://www.github.com/googleapis/java-bigtable/issues/410)) ([71dc8e3](https://www.github.com/googleapis/java-bigtable/commit/71dc8e3419fbb49d48bb7a3fd984d24e24661c81))
* Filters should be serializable ([googleapis#397](https://www.github.com/googleapis/java-bigtable/issues/397)) ([57edfde](https://www.github.com/googleapis/java-bigtable/commit/57edfde5eace28d50ec777e14589c9747616f0a8))
* RowCells are not actually serializeable ([googleapis#407](https://www.github.com/googleapis/java-bigtable/issues/407)) ([39e17cc](https://www.github.com/googleapis/java-bigtable/commit/39e17cc17c438f2d665875f9ff2b2cdf984e37b7))
* Fix race condition in Batcher.close() (via gax upgrade)
### Dependencies
* update dependency com.google.cloud:google-cloud-conformance-tests to v0.0.12 ([googleapis#415](https://www.github.com/googleapis/java-bigtable/issues/415)) ([7b3713a](https://www.github.com/googleapis/java-bigtable/commit/7b3713a8935b2f0b1ca57d189e9e0363506b28a1))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.10.0 ([googleapis#428](https://www.github.com/googleapis/java-bigtable/issues/428)) ([373032e](https://www.github.com/googleapis/java-bigtable/commit/373032e93b838cbc0ccab7dc45cd61b3b973542a))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.10.1 ([googleapis#443](https://www.github.com/googleapis/java-bigtable/issues/443)) ([939fefa](https://www.github.com/googleapis/java-bigtable/commit/939fefa819d09885489d9faeedadc74ee2b0e1b9))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v0.9.1 ([googleapis#427](https://www.github.com/googleapis/java-bigtable/issues/427)) ([5175e28](https://www.github.com/googleapis/java-bigtable/commit/5175e28f5ce69f6fb3ed14131c1cfd26dbc47bb9))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtableIssues related to the googleapis/java-bigtable API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add documentation to bulkReadRows that each batch will process the keys sequentially

3 participants

@dmitry-fa@igorbernstein2@vermas2012