Skip to content

chore: Refactoring retrier creation from HttpStorageOptions to StorageOptions - #3350

Merged
BenWhitehead merged 4 commits into
staged-mpu-merge-trainfrom
mpu-feature-1
Nov 3, 2025
Merged

chore: Refactoring retrier creation from HttpStorageOptions to StorageOptions#3350
BenWhitehead merged 4 commits into
staged-mpu-merge-trainfrom
mpu-feature-1

Conversation

@ShreyasSinha

@ShreyasSinhaShreyasSinha commented Oct 14, 2025

Copy link
Copy Markdown
Collaborator

Refer: #3348

@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. api: storage Issues related to the googleapis/java-storage API. labels Oct 14, 2025
@ShreyasSinha
ShreyasSinhaforce-pushed the mpu-feature-1 branch 2 times, most recently from 4e083b3 to 356fb56CompareOctober 15, 2025 04:31
@ShreyasSinhaShreyasSinha changed the title chore:Refactored retrier creation out of HttpStorageOptions to StorageOptionschore: Refactor retrier creation from HttpStorageOptions to StorageOptionsOct 15, 2025
@ShreyasSinha
ShreyasSinhaforce-pushed the mpu-feature-1 branch 2 times, most recently from 82d822f to e83a64aCompareOctober 15, 2025 06:58
@ShreyasSinha
ShreyasSinha marked this pull request as ready for review October 16, 2025 08:31
@ShreyasSinha
ShreyasSinha requested a review from a teamOctober 16, 2025 08:31
@ShreyasSinhaShreyasSinha added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Oct 16, 2025
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 16, 2025
@ShreyasSinhaShreyasSinha added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 16, 2025
@yoshi-kokoroyoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 16, 2025
@ShreyasSinhaShreyasSinha added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 20, 2025
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 20, 2025
@ShreyasSinhaShreyasSinha added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 20, 2025
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 20, 2025
@ShreyasSinhaShreyasSinha added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Oct 20, 2025
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 21, 2025
@ShreyasSinhaShreyasSinha changed the title chore: Refactor retrier creation from HttpStorageOptions to StorageOptionschore: Refactoring retrier creation from HttpStorageOptions to StorageOptionsOct 21, 2025
BenWhitehead
BenWhitehead requested changes Oct 21, 2025
View reviewed changes
Comment threadsamples/snippets/src/test/java/com/example/storage/ITBucketSnippets.java Outdated
Comment threadgoogle-cloud-storage/src/main/java/com/google/cloud/storage/StorageOptions.java
BenWhitehead
BenWhitehead requested changes Oct 22, 2025
View reviewed changes
Comment threadgoogle-cloud-storage/src/main/java/com/google/cloud/storage/HttpStorageOptions.java Outdated
ShreyasSinhaand others added 2 commits October 22, 2025 22:36
@ShreyasSinha@BenWhitehead
Apply suggestion from@BenWhitehead
8cc20aa
Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
@ShreyasSinha
chore: fixing lint issues
e29cadd
BenWhitehead
BenWhitehead reviewed Oct 22, 2025
View reviewed changes

@BenWhiteheadBenWhitehead left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I want to hold off merging for now

@BenWhiteheadBenWhitehead mentioned this pull request Oct 30, 2025
Merged
10 tasks
BenWhitehead
BenWhitehead approved these changes Oct 31, 2025
View reviewed changes

@BenWhiteheadBenWhitehead left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready for merge train

@BenWhitehead
BenWhitehead changed the base branch from main to staged-mpu-merge-trainNovember 3, 2025 21:05
@BenWhitehead
BenWhitehead merged commit c691cbb into staged-mpu-merge-trainNov 3, 2025
24 of 25 checks passed
@BenWhitehead
BenWhitehead deleted the mpu-feature-1 branch November 3, 2025 21:06
BenWhitehead added a commit that referenced this pull request Nov 3, 2025
@ShreyasSinha@BenWhitehead
chore: mpu client preview merge train
479ffee
BEGIN_NESTED_COMMIT
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#createMultipartUpload #3356
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#listParts #3359
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#abortMultipartUpload #3361
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#uploadPart #3375
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#completeMultipartUpload #3372
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadSettings
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
END_COMMIT_OVERRIDE
END_NESTED_COMMIT
Other changes:
1. chore: refactor retrier creation from HttpStorageOptions to StorageOptions #3350
2. chore: refactorings for CreateMultipartUpload #3364
3. chore: fix xml parsing of StringEnumValue's so that the enum contract is not broken #3377
4. chore: add PredefinedAcl#xmlEntry
Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
BenWhitehead added a commit that referenced this pull request Nov 3, 2025
@ShreyasSinha@BenWhitehead
chore: mpu client preview merge train
7ad9fa4
BEGIN_NESTED_COMMIT
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#createMultipartUpload #3356
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#listParts #3359
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#abortMultipartUpload #3361
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#uploadPart #3375
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#completeMultipartUpload #3372
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadSettings
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
END_COMMIT_OVERRIDE
END_NESTED_COMMIT
Other changes:
1. chore: refactor retrier creation from HttpStorageOptions to StorageOptions #3350
2. chore: refactorings for CreateMultipartUpload #3364
3. chore: fix xml parsing of StringEnumValue's so that the enum contract is not broken #3377
4. chore: add PredefinedAcl#xmlEntry
Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
BenWhitehead added a commit that referenced this pull request Nov 3, 2025
@ShreyasSinha@BenWhitehead
chore: mpu client preview merge train
160fa9a
BEGIN_NESTED_COMMIT
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#createMultipartUpload #3356
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#listParts #3359
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#abortMultipartUpload #3361
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#uploadPart #3375
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#completeMultipartUpload #3372
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadSettings
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
END_COMMIT_OVERRIDE
END_NESTED_COMMIT
Other changes:
1. chore: refactor retrier creation from HttpStorageOptions to StorageOptions #3350
2. chore: refactorings for CreateMultipartUpload #3364
3. chore: fix xml parsing of StringEnumValue's so that the enum contract is not broken #3377
4. chore: add PredefinedAcl#xmlEntry
Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
@BenWhitehead

BenWhitehead commented Nov 3, 2025

Copy link
Copy Markdown
Collaborator

merged to main in #3378

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenWhiteheadBenWhiteheadBenWhitehead approved these changes

Assignees

No one assigned

Labels

api: storageIssues related to the googleapis/java-storage API.size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShreyasSinha@BenWhitehead@yoshi-kokoro