Skip to content

feat: add preview MultipartUploadClient#completeMultipartUpload - #3372

Closed
ShreyasSinha wants to merge 18 commits into
mpu-feature-5from
mpu-feature-7
Closed

feat: add preview MultipartUploadClient#completeMultipartUpload#3372
ShreyasSinha wants to merge 18 commits into
mpu-feature-5from
mpu-feature-7

Conversation

@ShreyasSinha

@ShreyasSinhaShreyasSinha commented Oct 30, 2025

Copy link
Copy Markdown
Collaborator

Adding model classes for CompleteMultipartUpload request and response.
Implementing complete for Multipart Upload.
Refer: #3348

@product-auto-labelproduct-auto-labelBot added size: l Pull request size is large. api: storage Issues related to the googleapis/java-storage API. labels Oct 30, 2025
@ShreyasSinha
ShreyasSinha marked this pull request as ready for review October 30, 2025 13:39
@ShreyasSinha
ShreyasSinha requested a review from a teamOctober 30, 2025 13:39
@ShreyasSinhaShreyasSinha added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 30, 2025
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 30, 2025
@BenWhiteheadBenWhitehead mentioned this pull request Oct 30, 2025
Merged
10 tasks
BenWhitehead
BenWhitehead requested changes Oct 30, 2025
View reviewed changes
Comment thread...-cloud-storage/src/main/java/com/google/cloud/storage/MultipartUploadHttpRequestManager.java Outdated
ShreyasSinhaand others added 2 commits October 31, 2025 16:34
@ShreyasSinha@BenWhitehead
Update google-cloud-storage/src/main/java/com/google/cloud/storage/Mu…
b7d9d2f
…ltipartUploadHttpRequestManager.java
Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
@ShreyasSinha
chore: adding lint fixes.
c8b113a
@BenWhitehead

BenWhitehead commented Oct 31, 2025

Copy link
Copy Markdown
Collaborator

You've got a compiler error, which is failing all your builds:

Error: /home/runner/work/java-storage/java-storage/google-cloud-storage/src/main/java/com/google/cloud/storage/MultipartUploadHttpRequestManager.java:[134,6] cannot find symbol
symbol: class Nullable
location: class com.google.cloud.storage.MultipartUploadHttpRequestManager

@BenWhiteheadBenWhitehead changed the title feat: Adding API for complete multipart upload.feat: add preview MultipartUploadClient#completeMultiparUploadNov 3, 2025
@BenWhiteheadBenWhitehead changed the title feat: add preview MultipartUploadClient#completeMultiparUploadfeat: add preview MultipartUploadClient#completeMultipartUploadNov 3, 2025
BenWhitehead added a commit that referenced this pull request Nov 3, 2025
@ShreyasSinha@BenWhitehead
chore: mpu client preview merge train
479ffee
BEGIN_NESTED_COMMIT
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#createMultipartUpload #3356
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#listParts #3359
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#abortMultipartUpload #3361
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#uploadPart #3375
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#completeMultipartUpload #3372
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadSettings
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
END_COMMIT_OVERRIDE
END_NESTED_COMMIT
Other changes:
1. chore: refactor retrier creation from HttpStorageOptions to StorageOptions #3350
2. chore: refactorings for CreateMultipartUpload #3364
3. chore: fix xml parsing of StringEnumValue's so that the enum contract is not broken #3377
4. chore: add PredefinedAcl#xmlEntry
Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
BenWhitehead added a commit that referenced this pull request Nov 3, 2025
@ShreyasSinha@BenWhitehead
chore: mpu client preview merge train
7ad9fa4
BEGIN_NESTED_COMMIT
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#createMultipartUpload #3356
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#listParts #3359
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#abortMultipartUpload #3361
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#uploadPart #3375
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#completeMultipartUpload #3372
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadSettings
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
END_COMMIT_OVERRIDE
END_NESTED_COMMIT
Other changes:
1. chore: refactor retrier creation from HttpStorageOptions to StorageOptions #3350
2. chore: refactorings for CreateMultipartUpload #3364
3. chore: fix xml parsing of StringEnumValue's so that the enum contract is not broken #3377
4. chore: add PredefinedAcl#xmlEntry
Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
BenWhitehead added a commit that referenced this pull request Nov 3, 2025
@ShreyasSinha@BenWhitehead
chore: mpu client preview merge train
160fa9a
BEGIN_NESTED_COMMIT
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#createMultipartUpload #3356
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#listParts #3359
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#abortMultipartUpload #3361
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#uploadPart #3375
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadClient#completeMultipartUpload #3372
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
feat: add preview MultipartUploadSettings
END_COMMIT_OVERRIDE
BEGIN_COMMIT_OVERRIDE
END_COMMIT_OVERRIDE
END_NESTED_COMMIT
Other changes:
1. chore: refactor retrier creation from HttpStorageOptions to StorageOptions #3350
2. chore: refactorings for CreateMultipartUpload #3364
3. chore: fix xml parsing of StringEnumValue's so that the enum contract is not broken #3377
4. chore: add PredefinedAcl#xmlEntry
Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
@BenWhitehead

BenWhitehead commented Nov 3, 2025

Copy link
Copy Markdown
Collaborator

merged to main in #3378

@BenWhitehead
BenWhitehead deleted the mpu-feature-7 branch November 3, 2025 23:51
@release-pleaserelease-pleaseBot mentioned this pull request Nov 3, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenWhiteheadBenWhiteheadBenWhitehead approved these changes

Assignees

No one assigned

Labels

api: storageIssues related to the googleapis/java-storage API.size: lPull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShreyasSinha@BenWhitehead@yoshi-kokoro