Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Feb 23, 2026. It is now read-only.
fix: resolve issue handling protobuf responses in rest streaming - #604
Merged
Conversation
partheaforce-pushed
the
fix-rest-streaming
branch
from
February 12, 2024 20:53
c9e3277 to
4a92058Comparepartheaforce-pushed
the
fix-rest-streaming
branch
from
February 12, 2024 21:01
4a92058 to
ad79bf0Compareparthea
marked this pull request as ready for review
February 12, 2024 21:01
vchudnov-g
approved these changes
Feb 13, 2024
vchudnov-g
left a comment
Contributor
There was a problem hiding this comment.
A few minor comments, but LGTM.
| return self._response_message_cls.from_json(self._ready_objs.popleft()) | ||
| if issubclass(self._response_message_cls, proto.Message): | ||
| return self._response_message_cls.from_json(self._ready_objs.popleft()) | ||
| else: |
Contributor
There was a problem hiding this comment.
nit: for safety and future-proofing, maybe this should be an elif and we check for google.protobuf.Message
(I realize we don't expect to ever have the second check fail if we get here....but "we don't expect" == "famous last words")
(not a blocker)
| responses = [EchoResponse(content="hello world"), EchoResponse(content="yes")] | ||
| @pytest.mark.parametrize( | ||
| "random_split,resp_message_is_proto_plus,response_type", | ||
| [(False, True, EchoResponse), (False, False, httpbody_pb2.HttpBody)], |
Contributor
There was a problem hiding this comment.
Given that you're not testing different combinations of resp_message_is_proto_plus and response_type, and that you're already switching on the first to construct the responses (which you have to because they take different parameters): I suggest you don't parametrize on response_type and instead, in the function, do
ifresp_message_is_proto_plus:
response_type=EchoResponseresponses= [EchoResponse(content="hello world"), EchoResponse(content="yes")]
else:
response_type=httpbody_pb2.HttpBodyresponses= [
httpbody_pb2.HttpBody(content_type="hello world"),
httpbody_pb2.HttpBody(content_type="yes"),
]| Song(title="another song", date_added=datetime.datetime(2021, 12, 17)), | ||
| ] | ||
| @pytest.mark.parametrize( | ||
| "random_split,resp_message_is_proto_plus,response_type", |
Contributor
There was a problem hiding this comment.
Same comment as above: since you have the if below already, don't parametrize on response_type
| @pytest.mark.parametrize("random_split", [True, False]) | ||
| def test_next_stress(random_split): | ||
| @pytest.mark.parametrize( | ||
| "random_split,resp_message_is_proto_plus,response_type", |
| ), | ||
| Song(title='\\{"key": ["value",]}\\', composer=composer_with_relateds), | ||
| ] | ||
| @pytest.mark.parametrize( |
…essage or google.protobuf.message.Message
This was referenced Feb 13, 2024
ContributorAuthor
/cherry-pick v1 |
parthea added a commit
that referenced
this pull request
Feb 13, 2024
* fix: resolve issue handling protobuf responses in rest streaming * raise ValueError if response_message_cls is not a subclass of proto.Message or google.protobuf.message.Message * remove response_type from pytest.mark.parametrize * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * add test for ValueError in response_iterator._grab() --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
commented
Feb 13, 2024
ContributorAuthor
/cherry-pick v1 |
gcp-cherry-pick-botBot
pushed a commit
that referenced
this pull request
Feb 13, 2024
* fix: resolve issue handling protobuf responses in rest streaming * raise ValueError if response_message_cls is not a subclass of proto.Message or google.protobuf.message.Message * remove response_type from pytest.mark.parametrize * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * add test for ValueError in response_iterator._grab() --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards b/311671723