Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

fix(v1): resolve issue handling protobuf responses in rest streaming - #609

Merged
parthea merged 2 commits into
v1from
cherry-pick-c8ba66-v1
Feb 13, 2024
Merged

fix(v1): resolve issue handling protobuf responses in rest streaming#609
parthea merged 2 commits into
v1from
cherry-pick-c8ba66-v1

Conversation

@gcp-cherry-pick-bot

Copy link
Copy Markdown

Cherry-picked fix: resolve issue handling protobuf responses in rest streaming (#604)

  • fix: resolve issue handling protobuf responses in rest streaming

  • raise ValueError if response_message_cls is not a subclass of proto.Message or google.protobuf.message.Message

  • remove response_type from pytest.mark.parametrize

  • 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

  • add test for ValueError in response_iterator._grab()

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* fix: resolve issue handling protobuf responses in rest streaming
* raise ValueError if response_message_cls is not a subclass of proto.Message or google.protobuf.message.Message
* remove response_type from pytest.mark.parametrize
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
* add test for ValueError in response_iterator._grab()
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@gcp-cherry-pick-bot
gcp-cherry-pick-botBot requested review from a teamFebruary 13, 2024 17:03
@product-auto-labelproduct-auto-labelBot added the size: l Pull request size is large. label Feb 13, 2024
@partheaparthea changed the title fix: resolve issue handling protobuf responses in rest streaming (#604) * fix: resolve issue handling protobuf responses in rest streaming * raise ValueError if response_message_cls is not a subclass of proto.Message or google.protobuf.message.Message * remove response_type from pytest.mark.parametrize * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * add test for ValueError in response_iterator._grab() --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>fix: resolve issue handling protobuf responses in rest streamingFeb 13, 2024
@partheaparthea changed the title fix: resolve issue handling protobuf responses in rest streamingfix(v1): resolve issue handling protobuf responses in rest streamingFeb 13, 2024
@parthea
parthea merged commit d386d2e into v1Feb 13, 2024
@parthea
parthea deleted the cherry-pick-c8ba66-v1 branch February 13, 2024 17:25
@release-pleaserelease-pleaseBot mentioned this pull request Feb 13, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: lPull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ohmayr@parthea