Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

chore: move retry async check to wrap time - #668

Merged
parthea merged 7 commits into
mainfrom
move_async_warning
Oct 21, 2024
Merged

chore: move retry async check to wrap time#668
parthea merged 7 commits into
mainfrom
move_async_warning

Conversation

@parthea

@partheaparthea commented Jun 5, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Opening a new PR to restore the features in #649 which were reverted in #667 due to tests failing in cl/640306895

cc @daniel-sanche

@product-auto-labelproduct-auto-labelBot added the size: s Pull request size is small. label Jun 5, 2024
daniel-sanche
daniel-sanche approved these changes Aug 5, 2024
View reviewed changes

@daniel-sanchedaniel-sanche left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@partheaparthea self-assigned this Oct 9, 2024
@partheaparthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 9, 2024
@partheaparthea changed the title Move async warningchore: move retry async check to wrap timeOct 21, 2024
@partheaparthea added the status: investigating The issue is under investigation, which is determined to be non-trivial. label Oct 21, 2024
@parthea

parthea commented Oct 21, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Waiting for test results in cl/688122871 Tests passed

@partheaparthea removed status: investigating The issue is under investigation, which is determined to be non-trivial. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Oct 21, 2024
@parthea
parthea marked this pull request as ready for review October 21, 2024 14:45
@parthea
parthea requested review from a teamOctober 21, 2024 14:45
@parthea
parthea merged commit 3c69867 into mainOct 21, 2024
@parthea
parthea deleted the move_async_warning branch October 21, 2024 14:46
parthea added a commit that referenced this pull request Oct 22, 2024
@parthea
Revert "chore: move retry async check to wrap time (#668)"
c4880c3
This reverts commit 3c69867.
@partheaparthea mentioned this pull request Oct 22, 2024
Merged
parthea added a commit that referenced this pull request Oct 22, 2024
@parthea
chore: Revert "chore: move retry async check to wrap time (#668)" (#743)
7727405
This reverts commit 3c69867.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@daniel-sanchedaniel-sanchedaniel-sanche approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@partheaparthea

Labels

size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@parthea@daniel-sanche