Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

chore: Revert "chore: move retry async check to wrap time" - #743

Merged
parthea merged 1 commit into
mainfrom
revert-668-move_async_warning
Oct 22, 2024
Merged

chore: Revert "chore: move retry async check to wrap time"#743
parthea merged 1 commit into
mainfrom
revert-668-move_async_warning

Conversation

@parthea

@partheaparthea commented Oct 22, 2024

Copy link
Copy Markdown
Contributor

Reverts #668

PR #668 causes tests to fail in the python-bigquery repository. See build log here from PR googleapis/python-bigquery#2045.

E AssertionError: Calls not found.
E Expected: [call(method='POST', path='/projects/test-project-123/jobs', data={'jobReference': {'jobId': 'job-id', 'projectId': 'test-project-123'}}, timeout=None),
E call(method='POST', path='/projects/test-project-123/jobs', data={'jobReference': {'jobId': 'job-id', 'projectId': 'test-project-123'}}, timeout=None),
E call(method='GET', path='/projects/test-project-123/jobs/job-id', query_params={'projection': 'full', 'location': 'US'}, timeout=128)]
E Actual: [call.__code__.co_flags.__and__(128),
E call.__code__.co_flags.__and__().__bool__(),
E call(method='POST', path='/projects/test-project-123/jobs', data={'jobReference': {'jobId': 'job-id', 'projectId': 'test-project-123'}}, timeout=None),
E call(method='POST', path='/projects/test-project-123/jobs', data={'jobReference': {'jobId': 'job-id', 'projectId': 'test-project-123'}}, timeout=None),
E call.__code__.co_flags.__and__(128),
E call.__code__.co_flags.__and__().__bool__(),
E call(method='GET', path='/projects/test-project-123/jobs/job-id', query_params={'projection': 'full', 'location': 'US'}, timeout=128)]

@parthea
parthea requested review from a teamOctober 22, 2024 17:22
@product-auto-labelproduct-auto-labelBot added the size: s Pull request size is small. label Oct 22, 2024

@tswasttswast left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THanks!

@parthea
parthea merged commit 7727405 into mainOct 22, 2024
@parthea
parthea deleted the revert-668-move_async_warning branch October 22, 2024 17:29
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: sPull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@parthea@tswast@vchudnov-g