Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Feb 23, 2026. It is now read-only.
fix: closes tailing streams in bidi classes. - #851
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
daniel-sanche
commented
Oct 29, 2025
Contributor
I think we'll need a similar change on the async side as well: https://github.com/chandra-siri/python-api-core/blob/82cea4f767510be2002fcc5807a770b99a2906c1/google/api_core/bidi_async.py#L198 |
pujawadare
commented
Oct 29, 2025
pujawadare
left a comment
ContributorAuthor
There was a problem hiding this comment.
Also included async bidi classes in the fix.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
daniel-sanche
previously approved these changes
Oct 29, 2025
pujawadareforce-pushed
the
bidi-close
branch
2 times, most recently
from
October 30, 2025 06:04
7da01b3 to
6768183CompareAlways put `None` into the request queue when closing a bidi stream. This ensures that the request queue is always signaled as closed, even if the underlying gRPC call object is not yet available.
daniel-sanche
approved these changes
Oct 30, 2025
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jan 8, 2026
daniel-sanche added a commit
that referenced
this pull request
Jan 8, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v1.0.1 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620 <details><summary>google-api-core: 2.29.0</summary> ## [2.29.0](v2.28.1...v2.29.0) (2026-01-08) ### Features * make parse_version_to_tuple public (#864) ([c969186](c969186f)) * Auto enable mTLS when supported certificates are detected (#869) ([f8bf6f9](f8bf6f96)) ### Bug Fixes * remove call to importlib.metadata.packages_distributions() for py38/py39 (#859) ([628003e](628003e2)) * Log version check errors (#858) ([6493118](6493118c)) * flaky tests due to imprecision in floating point calculation and performance test setup (#865) ([9340408](93404080)) * closes tailing streams in bidi classes. (#851) ([c97b3a0](c97b3a00)) </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always put
Noneinto the request queue when closing a bidi stream. This ensures that the request queue is always signaled as closed, even if the underlying gRPC call object is not yet available.Fixes#850 🦕