Skip to content
This repository was archived by the owner on Feb 23, 2026. It is now read-only.

fix: Log version check errors - #858

Merged
chalmerlowe merged 4 commits into
googleapis:mainfrom
ReubenFrankel:fix/version-check-error-log
Nov 4, 2025
Merged

fix: Log version check errors#858
chalmerlowe merged 4 commits into
googleapis:mainfrom
ReubenFrankel:fix/version-check-error-log

Conversation

@ReubenFrankel

@ReubenFrankelReubenFrankel commented Oct 31, 2025

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Partially addresses #857 🦕

@ReubenFrankel
ReubenFrankel requested review from a teamOctober 31, 2025 04:43
@google-cla

google-claBot commented Oct 31, 2025

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-labelproduct-auto-labelBot added the size: s Pull request size is small. label Oct 31, 2025
@ReubenFrankelReubenFrankel changed the title Fix/version check error logfix: Log version check errorsOct 31, 2025
chalmerlowe
chalmerlowe reviewed Nov 4, 2025
View reviewed changes
Comment threadgoogle/api_core/_python_version_support.py Outdated
@chalmerlowe

chalmerlowe commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

@ReubenFrankel Thanks for this PR. I would like to see the logger type and message modified a bit. Please accept the suggestion and I will approve.

If you have a strong objection to the suggestion, I am happy to hear your reasoning.

@ReubenFrankel@chalmerlowe
Update google/api_core/_python_version_support.py
b3db261
Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
@ReubenFrankel

ReubenFrankel commented Nov 4, 2025

Copy link
Copy Markdown
ContributorAuthor

If you have a strong objection to the suggestion, I am happy to hear your reasoning.

No objections, I kept the message the same only because that was what was there before and the intention of the PR was to move from print to logging.

chalmerlowe
chalmerlowe previously approved these changes Nov 4, 2025
View reviewed changes

@chalmerlowechalmerlowe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ReubenFrankel

ReubenFrankel commented Nov 4, 2025

Copy link
Copy Markdown
ContributorAuthor

If the fix for underlying cause is simple (i.e. adjusting the version check), I'm happy to expand this PR to cover that also.

@ReubenFrankel
ReubenFrankelforce-pushed the fix/version-check-error-log branch from 923af21 to 1314e81CompareNovember 4, 2025 12:10
@chalmerlowechalmerlowe added the automerge Merge the pull request once unit tests and other checks pass. label Nov 4, 2025
@Linchin
Linchin self-requested a review November 4, 2025 19:26
@chalmerlowe
chalmerlowe merged commit 6493118 into googleapis:mainNov 4, 2025
45 of 46 checks passed
@chalmerlowe

chalmerlowe commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

Thank you @ReubenFrankel!

@ReubenFrankel
ReubenFrankel deleted the fix/version-check-error-log branch November 4, 2025 21:12
@vchudnov-gvchudnov-g mentioned this pull request Nov 20, 2025
Closed
This was referenced Jan 8, 2026
Closed
Merged
daniel-sanche added a commit that referenced this pull request Jan 8, 2026
@daniel-sanche
chore: librarian release pull request: 20260108T134327Z (#883)
014d3de
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.
Librarian Version: v1.0.1
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620
<details><summary>google-api-core: 2.29.0</summary>
##
[2.29.0](v2.28.1...v2.29.0)
(2026-01-08)
### Features
* make parse_version_to_tuple public (#864)
([c969186](c969186f))
* Auto enable mTLS when supported certificates are detected (#869)
([f8bf6f9](f8bf6f96))
### Bug Fixes
* remove call to importlib.metadata.packages_distributions() for
py38/py39 (#859)
([628003e](628003e2))
* Log version check errors (#858)
([6493118](6493118c))
* flaky tests due to imprecision in floating point calculation and
performance test setup (#865)
([9340408](93404080))
* closes tailing streams in bidi classes. (#851)
([c97b3a0](c97b3a00))
</details>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers
@partheapartheaparthea approved these changes
@LinchinLinchinLinchin approved these changes
@chalmerlowechalmerlowechalmerlowe left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@gkevinzhenggkevinzheng

Labels

automergeMerge the pull request once unit tests and other checks pass.size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ReubenFrankel@chalmerlowe@parthea@Linchin@gkevinzheng