Skip to content
This repository was archived by the owner on Nov 12, 2025. It is now read-only.

feat: introduce compatibility with native namespace packages - #706

Merged
Linchin merged 10 commits into
googleapis:mainfrom
kiraksi:native-namespace-compatibility
Dec 1, 2023
Merged

feat: introduce compatibility with native namespace packages#706
Linchin merged 10 commits into
googleapis:mainfrom
kiraksi:native-namespace-compatibility

Conversation

@kiraksi

@kiraksikiraksi commented Nov 14, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR:

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#705 🦕

@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. labels Nov 14, 2023
@kiraksikiraksi self-assigned this Nov 14, 2023
@kiraksi
kiraksi marked this pull request as ready for review November 14, 2023 00:52
@kiraksi
kiraksi requested review from a teamNovember 14, 2023 00:52
@kiraksikiraksi added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 14, 2023
@parthea

parthea commented Nov 14, 2023

Copy link
Copy Markdown
Contributor

There is an upcoming release freeze. This should be merged after the release freeze ends on November 29th.

parthea
parthea reviewed Nov 14, 2023
View reviewed changes

@partheaparthea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please could you also remove usage of pkg_resources here? Please feel free to make the change in this PR or a separate PR. This should allow us to close #482

python-bigquery-storage/tests/unit/test_reader_v1_arrow.py

Line 23 in 20b57c2

importpkg_resources

@kiraksikiraksi linked an issue Nov 14, 2023 that may be closed by this pull request
DistributionNotFound error potentially caused by pkg_resources #482
Closed
@kiraksikiraksi removed a link to an issue Nov 14, 2023
DistributionNotFound error potentially caused by pkg_resources #482
Closed
@kiraksi
kiraksiforce-pushed the native-namespace-compatibility branch from b47238d to a85ddcaCompareNovember 14, 2023 17:44
@kiraksi

kiraksi commented Nov 14, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

LGTM, please could you also remove usage of pkg_resources here? Please feel free to make the change in this PR or a separate PR. This should allow us to close #482

python-bigquery-storage/tests/unit/test_reader_v1_arrow.py

Line 23 in 20b57c2

importpkg_resources

Edit: Will be done in this PR

@kiraksikiraksi linked an issue Nov 15, 2023 that may be closed by this pull request
DistributionNotFound error potentially caused by pkg_resources #482
Closed
parthea
parthea reviewed Nov 15, 2023
View reviewed changes

@partheaparthea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor observations. Otherwise LGTM

Comment threadsetup.py Outdated
Comment threadtests/unit/test_reader_v1_arrow.py Outdated
Comment threadtests/unit/test_reader_v1_arrow.py Outdated
@kiraksi
kiraksi requested a review from partheaNovember 16, 2023 18:34
@kiraksikiraksi mentioned this pull request Nov 16, 2023
Closed
@kiraksikiraksi mentioned this pull request Nov 16, 2023
Merged
4 tasks
@partheaparthea mentioned this pull request Nov 22, 2023
Closed
@kiraksikiraksi removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 28, 2023
parthea
parthea suggested changes Nov 30, 2023
View reviewed changes

@partheaparthea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to migrate setup.py to use setuptoolsfind_namespace_packages(.. instead of setuptools.PEP420PackageFinder.find()

@parthea
parthea self-requested a review December 1, 2023 21:39
@Linchin
Linchin merged commit 59f9564 into googleapis:mainDec 1, 2023
@release-pleaserelease-pleaseBot mentioned this pull request Dec 1, 2023
Merged
@kiraksi
kiraksi deleted the native-namespace-compatibility branch January 17, 2024 13:59
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chalmerlowechalmerloweAwaiting requested review from chalmerlowe
2 more reviewers
@partheapartheaparthea approved these changes
@LinchinLinchinLinchin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@kiraksikiraksi

Labels

api: bigquerystorageIssues related to the googleapis/python-bigquery-storage API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

use native support for namespace packages DistributionNotFound error potentially caused by pkg_resources

3 participants

@kiraksi@parthea@Linchin