Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Mar 6, 2026. It is now read-only.
feat: Introduce compatibility with native namespace packages - #1720
Closed
parthea wants to merge 2 commits into
Closed
feat: Introduce compatibility with native namespace packages#1720parthea wants to merge 2 commits into
parthea wants to merge 2 commits into
Conversation
partheaforce-pushed
the
migrate-to-native-namespace-packages
branch
3 times, most recently
from
November 13, 2023 17:58
695affd to
fbeb2b0Compareparthea
commented
Nov 13, 2023
ContributorAuthor
Adding |
partheaforce-pushed
the
migrate-to-native-namespace-packages
branch
from
November 13, 2023 20:24
fbeb2b0 to
c9a0753Comparepartheaforce-pushed
the
migrate-to-native-namespace-packages
branch
2 times, most recently
from
November 14, 2023 10:48
336a9dc to
e69ce81Comparepartheaforce-pushed
the
migrate-to-native-namespace-packages
branch
from
November 14, 2023 10:49
e69ce81 to
df642b0Compareparthea
marked this pull request as ready for review
November 14, 2023 15:05
Merged
4 tasks
kiraksi
approved these changes
Nov 16, 2023
| google.joinpath("othermod.py").write_text("") | ||
| env = dict(os.environ, PYTHONPATH=str(tmp_path)) | ||
| cmd = [sys.executable, "-m", "google.othermod"] | ||
| subprocess.check_call(cmd, env=env) |
Contributor
There was a problem hiding this comment.
Were you able to run this test with subprocess without specifying to do it in the shell? It wasn't able to find the tmp path without me specifying to run in the shell, which is the small edit I did in the other PR for this
This was referenced Nov 16, 2023
parthea
commented
Nov 21, 2023
ContributorAuthor
Superseded by #1726 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to googleapis/google-auth-library-python#1205
Also see https://packaging.python.org/en/latest/guides/packaging-namespace-packages/#native-namespace-packages
Fixes#313 🦕