Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

feat: support authorized dataset entity - #1075

Merged
tswast merged 10 commits into
googleapis:mainfrom
steffnay:remove-entity-val
Dec 14, 2021
Merged

feat: support authorized dataset entity#1075
tswast merged 10 commits into
googleapis:mainfrom
steffnay:remove-entity-val

Conversation

@steffnay

@steffnaysteffnay commented Nov 30, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Removes the client-side validation of entity types and replaces them with enum values.

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#1064 🦕

@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Nov 30, 2021
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Nov 30, 2021
@steffnay
steffnay marked this pull request as ready for review November 30, 2021 22:04
@steffnay
steffnay requested review from a team, loferris and tswastNovember 30, 2021 22:04
@tswasttswast mentioned this pull request Dec 1, 2021
Closed
tswast
tswast suggested changes Dec 1, 2021
View reviewed changes
Comment threadgoogle/cloud/bigquery/enums.py Outdated
Comment threadtests/unit/test_dataset.py
Comment threadgoogle/cloud/bigquery/dataset.py
@tswast

tswast commented Dec 6, 2021

Copy link
Copy Markdown
Contributor

Let's make sure we update the code samples with the new enum too.

python-bigquery/samples/snippets/authorized_view_tutorial.py

Line 109 in 679e8ed

bigquery.AccessEntry("READER", "groupByEmail", analyst_group_email)

python-bigquery/samples/snippets/update_dataset_access.py

Line 40 in effd673

entity_type="groupByEmail"

@steffnay
steffnay requested a review from a team as a code ownerDecember 6, 2021 23:46
@steffnay
steffnay requested a review from tswastDecember 7, 2021 18:58
steffnay
steffnay commented Dec 7, 2021
View reviewed changes
Comment threadgoogle/cloud/bigquery/dataset.py
tswast
tswast suggested changes Dec 8, 2021
View reviewed changes
Comment threadtests/unit/test_dataset.py
@steffnay
steffnay requested a review from tswastDecember 13, 2021 23:31
@tswast
tswast merged commit c098cd0 into googleapis:mainDec 14, 2021
This was referenced Jan 4, 2022
Closed
Merged
gcf-merge-on-greenBot pushed a commit that referenced this pull request Jan 13, 2022
@release-please
chore(main): release 2.32.0 (#1104)
643b333
🤖 I have created a release *beep* *boop*
---
## [2.32.0](v2.31.0...v2.32.0) (2022-01-12)
### Features
* support authorized dataset entity ([#1075](#1075)) ([c098cd0](c098cd0))
### Bug Fixes
* remove query text from exception message, use `exception.debug_message` instead ([#1105](#1105)) ([e23114c](e23114c))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@release-pleaserelease-pleaseBot mentioned this pull request Jan 13, 2022
Closed
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@steffnay@abdelmegahedgoogle
feat: support authorized dataset entity (googleapis#1075)
f01e666
* feat: support authorized dataset entity
* cleanup
* add test and cache the resource from from_api_repr in a _properties value
* lint
* update samples to use enums
* update to_api_repr and add tests
* refactor
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@release-please@abdelmegahedgoogle
chore(main): release 2.32.0 (googleapis#1104)
742edc9
🤖 I have created a release *beep* *boop*
---
## [2.32.0](googleapis/python-bigquery@v2.31.0...v2.32.0) (2022-01-12)
### Features
* support authorized dataset entity ([googleapis#1075](googleapis#1075)) ([c098cd0](googleapis@c098cd0))
### Bug Fixes
* remove query text from exception message, use `exception.debug_message` instead ([googleapis#1105](googleapis#1105)) ([e23114c](googleapis@e23114c))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Mar 6, 2026
@release-please
chore(main): release 2.32.0 (#1104)
a19a2f1
🤖 I have created a release *beep* *boop*
---
## [2.32.0](googleapis/python-bigquery@v2.31.0...v2.32.0) (2022-01-12)
### Features
* support authorized dataset entity ([#1075](googleapis/python-bigquery#1075)) ([c098cd0](googleapis/python-bigquery@c098cd0))
### Bug Fixes
* remove query text from exception message, use `exception.debug_message` instead ([#1105](googleapis/python-bigquery#1105)) ([e23114c](googleapis/python-bigquery@e23114c))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@loferrisloferrisAwaiting requested review from loferris
1 more reviewer
@tswasttswasttswast approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Authorized Dataset

2 participants

@steffnay@tswast