Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: remove query text from exception message, use exception.debug_message instead - #1105

Merged
tswast merged 1 commit into
mainfrom
b211616590-query-exception
Jan 12, 2022
Merged

fix: remove query text from exception message, use exception.debug_message instead#1105
tswast merged 1 commit into
mainfrom
b211616590-query-exception

Conversation

@tswast

Copy link
Copy Markdown
Contributor

Since query text can potentially contain sensitive information, remove it from
the default exception message. This information is useful for debugging, so
provide a debug_message attribute, which is not included in the exception
representation (and thus the logs).

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 211616590
🦕

…essage` instead
Since query text can potentially contain sensitive information, remove it from
the default exception message. This information is useful for debugging, so
provide a `debug_message` attribute, which is not included in the exception
representation (and thus the logs).
Fixes internal issue 211616590
@tswast
tswast requested review from a team and loferrisJanuary 11, 2022 22:53
@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Jan 11, 2022
@tswast
tswast requested a review from partheaJanuary 11, 2022 22:53
@tswast
tswast merged commit e23114c into mainJan 12, 2022
@tswast
tswast deleted the b211616590-query-exception branch January 12, 2022 21:25
@release-pleaserelease-pleaseBot mentioned this pull request Jan 12, 2022
gcf-merge-on-greenBot pushed a commit that referenced this pull request Jan 13, 2022
🤖 I have created a release *beep* *boop*
---
## [2.32.0](v2.31.0...v2.32.0) (2022-01-12)
### Features
* support authorized dataset entity ([#1075](#1075)) ([c098cd0](c098cd0))
### Bug Fixes
* remove query text from exception message, use `exception.debug_message` instead ([#1105](#1105)) ([e23114c](e23114c))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@release-pleaserelease-pleaseBot mentioned this pull request Jan 13, 2022
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
…essage` instead (googleapis#1105)
Since query text can potentially contain sensitive information, remove it from
the default exception message. This information is useful for debugging, so
provide a `debug_message` attribute, which is not included in the exception
representation (and thus the logs).
Fixes internal issue 211616590
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
🤖 I have created a release *beep* *boop*
---
## [2.32.0](googleapis/python-bigquery@v2.31.0...v2.32.0) (2022-01-12)
### Features
* support authorized dataset entity ([googleapis#1075](googleapis#1075)) ([c098cd0](googleapis@c098cd0))
### Bug Fixes
* remove query text from exception message, use `exception.debug_message` instead ([googleapis#1105](googleapis#1105)) ([e23114c](googleapis@e23114c))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Mar 6, 2026
🤖 I have created a release *beep* *boop*
---
## [2.32.0](googleapis/python-bigquery@v2.31.0...v2.32.0) (2022-01-12)
### Features
* support authorized dataset entity ([#1075](googleapis/python-bigquery#1075)) ([c098cd0](googleapis/python-bigquery@c098cd0))
### Bug Fixes
* remove query text from exception message, use `exception.debug_message` instead ([#1105](googleapis/python-bigquery#1105)) ([e23114c](googleapis/python-bigquery@e23114c))
---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@tswast@busunkim96