Uh oh!
There was an error while loading. Please reload this page.
fix: throw exception for data type mismatch for load_table_from_dataf… - #1824
fix: throw exception for data type mismatch for load_table_from_dataf…#1824Gaurang033 wants to merge 1 commit into
Conversation
chalmerlowe
commented
Feb 21, 2024
Thanks for jumping on this so quickly. We will likely need at least one new test to test this path. |
Gaurang033
commented
Feb 21, 2024
I can add a unit test for this if you like |
a2285b6 to
d976c09Compareba2ac46 to
06c357dCompare06c357d to
3a16f37Compare3a16f37 to
2d42fc6CompareGaurang033
commented
Mar 18, 2024
Unit test was failing as exception thrown in python 3.7 and 3.8 and higher version was different. changed the assertion to use regex and tested locally with both the version. Tests should pass now. |
chalmerlowe
commented
Mar 18, 2024
@Gaurang033 I took various parts of each of them and have merged them into a single PR. So please don't devote any additional time to this PR. |
chalmerlowe
commented
Mar 19, 2024
Closed by the merger of #1836 |
Fixes#1822