Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

fix: update error logging when converting to pyarrow column fails - #1836

Merged
chalmerlowe merged 31 commits into
mainfrom
name-series-in-error-log
Mar 19, 2024
Merged

fix: update error logging when converting to pyarrow column fails#1836
chalmerlowe merged 31 commits into
mainfrom
name-series-in-error-log

Conversation

@chalmerlowe

@chalmerlowechalmerlowe commented Feb 29, 2024•
edited
Loading

Copy link
Copy Markdown
Collaborator

When conversion of a pyarrow column fails, the user is not provided adequate information about which column fails to convert. This PR provides additional context to identify the column (if the Series has a .name parameter).

Fixes#1621 🦕
Fixes#1822

This merges and replaces the follow PR(s):
#1824
#1622

@chalmerlowe
chalmerlowe requested review from a team and obada-abFebruary 29, 2024 16:45
@product-auto-labelproduct-auto-labelBot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Feb 29, 2024
@chalmerlowe
chalmerlowe requested a review from a team as a code ownerFebruary 29, 2024 19:29
@chalmerlowe
chalmerlowe marked this pull request as draft February 29, 2024 19:30
This was referenced Mar 11, 2024
Closed
Closed
@chalmerlowechalmerlowe mentioned this pull request Mar 13, 2024
Closed
@product-auto-labelproduct-auto-labelBot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Mar 15, 2024
@chalmerlowe
chalmerlowe marked this pull request as ready for review March 18, 2024 14:16
@chalmerlowechalmerlowe mentioned this pull request Mar 18, 2024
Closed
Linchin
Linchin reviewed Mar 18, 2024
View reviewed changes
Comment threadgoogle/cloud/bigquery/_pandas_helpers.py Outdated
Linchin
Linchin reviewed Mar 18, 2024
View reviewed changes
Comment threadgoogle/cloud/bigquery/_pyarrow_helpers.py
Linchin
Linchin reviewed Mar 18, 2024
View reviewed changes
Comment threadgoogle/cloud/bigquery/_pandas_helpers.py
@Linchin

Linchin commented Mar 18, 2024

Copy link
Copy Markdown
Contributor

Thank you so much @chalmerlowe for fixing these issues! Mostly looks good, I just had some questions on the details.

@chalmerlowechalmerlowe added the automerge Merge the pull request once unit tests and other checks pass. label Mar 18, 2024
@gcf-merge-on-green

gcf-merge-on-greenBot commented Mar 19, 2024

Copy link
Copy Markdown

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 19, 2024
chalmerlowe
chalmerlowe commented Mar 19, 2024
View reviewed changes
Comment threadtests/unit/test__pandas_helpers.py Outdated
@chalmerlowe
chalmerlowe merged commit 0ac6e9b into mainMar 19, 2024
@chalmerlowe
chalmerlowe deleted the name-series-in-error-log branch March 19, 2024 13:51
@release-pleaserelease-pleaseBot mentioned this pull request Mar 18, 2024
Merged
This was referenced Apr 2, 2024
Closed
Closed
Closed
@j-blackwellj-blackwell mentioned this pull request Mar 2, 2026
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@obada-abobada-abAwaiting requested review from obada-ab
@engelkeengelkeAwaiting requested review from engelkeengelke is a code owner automatically assigned from googleapis/python-samples-owners
1 more reviewer
@LinchinLinchinLinchin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.size: mPull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Raised ArrowTypeError should indicates which column is causing the error Arrow conversion errors do not indicate problematic dataframe column.

2 participants

@chalmerlowe@Linchin