Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

testing: split system tests - #207

Merged
tseaver merged 5 commits into
googleapis:masterfrom
tmatsuo:split-systests
Aug 4, 2020
Merged

testing: split system tests#207
tseaver merged 5 commits into
googleapis:masterfrom
tmatsuo:split-systests

Conversation

@tmatsuo

@tmatsuotmatsuo commented Jul 31, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

I manually run synthtool with the changes in googleapis/synthtool#712

Motivation: #191

Note that noxfile.py is skipped, so I manually updated it (probably ok)

@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Jul 31, 2020
@tmatsuo

tmatsuo commented Aug 1, 2020

Copy link
Copy Markdown
ContributorAuthor

@tseaver@shollyman@busunkim96 I can not assign a reviewer or add a label. Can you review?

@tmatsuo

tmatsuo commented Aug 1, 2020•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I checked the test logs and they work as expected:

  • main presubmit build is skipping system tests.
  • system-x.x build is only running a system test for a single python version.
  • presubmit is the slowest. It took 24min 40secs.

Another observation is that the snippets tests are taking long time. Once we move them out, the build will be much faster.

@tseaver
tseaver self-requested a review August 3, 2020 17:45
tseaver
tseaver suggested changes Aug 3, 2020
View reviewed changes
Comment threadnoxfile.py
Comment threadsynth.py
Comment threaddocs/conf.py
@tmatsuo

tmatsuo commented Aug 3, 2020

Copy link
Copy Markdown
ContributorAuthor

@tseaver Thanks, I opened googleapis/synthtool#713 which will allow us to use the template.

@tmatsuo

tmatsuo commented Aug 3, 2020

Copy link
Copy Markdown
ContributorAuthor

@tseaver Tests are passing. I rebased to the master. PTAL

@tseaver
tseaver self-requested a review August 4, 2020 16:35
@tseaver
tseaver merged commit b842fb5 into googleapis:masterAug 4, 2020
@tmatsuotmatsuo mentioned this pull request Aug 4, 2020
Closed
1 task
@tseavertseaver mentioned this pull request Aug 10, 2020
Merged
jmgreger pushed a commit to jmgreger/python-bigquery that referenced this pull request Aug 31, 2020
Takashi MatsuoJonathan Greger
testing: split system tests into separate builds (googleapis#207)
9ceeafc
gcf-merge-on-greenBot pushed a commit that referenced this pull request Oct 16, 2020
@tseaver
tests: split out snippets builds (#219)
29dd573
@tmatsuo Emulating PR #207. I don't know if I'm missing anything: e.g., I don't quite understand what the `split_system_tests=True` does in the `synth.py` there.
Toward #191
@tseavertseaver mentioned this pull request Jul 20, 2021
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@plamutplamutAwaiting requested review from plamut
@shollymanshollymanAwaiting requested review from shollyman
1 more reviewer
@tseavertseavertseaver approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tmatsuo@tseaver