Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

tests: split out snippets builds - #219

Merged
gcf-merge-on-green[bot] merged 5 commits into
masterfrom
191-split-out-snippets-builds
Oct 16, 2020
Merged

tests: split out snippets builds#219
gcf-merge-on-green[bot] merged 5 commits into
masterfrom
191-split-out-snippets-builds

Conversation

@tseaver

Copy link
Copy Markdown
Contributor

@tmatsuo Emulating PR #207. I don't know if I'm missing anything: e.g., I don't quite understand what the split_system_tests=True does in the synth.py there.

Toward #191

@tseaver
tseaver requested a review from tmatsuoAugust 10, 2020 19:25
@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Aug 10, 2020
@product-auto-labelproduct-auto-labelBot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Aug 21, 2020

@tmatsuotmatsuo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply. Once we agree on the env var name, I can make a change for allowing the env var.

Comment thread.kokoro/presubmit/presubmit.cfg Outdated
value: "false"
}
env_vars: {
key: "RUN_SNIPPETS"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to allow this envvar in the Kokoro config in google3.
Also how about RUN_SNIPPETS_TESTS for consistensy?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RUN_SNIPPETS_TESTS sounds good to me

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to the Kokoro side configuration files.

@tswasttswast added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 16, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 16, 2020
@gcf-merge-on-green

Copy link
Copy Markdown

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green

Copy link
Copy Markdown

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

Comment thread.kokoro/presubmit/presubmit.cfg Outdated
value: "false"
}
env_vars: {
key: "RUN_SNIPPETS"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to the Kokoro side configuration files.

@gcf-merge-on-green
gcf-merge-on-greenBot merged commit 29dd573 into masterOct 16, 2020
@gcf-merge-on-greengcf-merge-on-greenBot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 16, 2020
@tswast
tswast deleted the 191-split-out-snippets-builds branch July 27, 2021 21:22
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigqueryIssues related to the googleapis/python-bigquery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tseaver@tmatsuo@tswast@yoshi-kokoro