Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Mar 6, 2026. It is now read-only.
chore: add unit test nox session without extras installed - #623
Merged
Conversation
plamut
requested review from
a team and stephaniewang526
and removed request for
a teamApril 22, 2021 12:36
plamut
commented
Apr 22, 2021
Comment on lines
+95
to
+96
| @nox.session(python=UNIT_TEST_PYTHON_VERSIONS[-1]) | ||
| def unit_noextras(session): |
ContributorAuthor
There was a problem hiding this comment.
Presumably using just the latest version is fine?
(the CI will finish faster)
On rare occasions an extra requires a more recent Python version, but I can't recall any cases when an extra would be restricted to older Python versions.
Contributor
There was a problem hiding this comment.
Sounds good to me. We could also use DEFAULT_PYTHON_VERSION here, though that's not always the latest.
tswast
approved these changes
Apr 23, 2021
Comment on lines
+95
to
+96
| @nox.session(python=UNIT_TEST_PYTHON_VERSIONS[-1]) | ||
| def unit_noextras(session): |
Contributor
There was a problem hiding this comment.
Sounds good to me. We could also use DEFAULT_PYTHON_VERSION here, though that's not always the latest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#621. 🦕
The new check revealed a few cases where not installing extras caused some of the tests to fail, but that was due to test setup, and not the codebase itself.
PR checklist: