Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

feat: ping and warm with metadata - #810

Merged
daniel-sanche merged 11 commits into
googleapis:v3from
daniel-sanche:warm_improvements
Jun 26, 2023
Merged

feat: ping and warm with metadata#810
daniel-sanche merged 11 commits into
googleapis:v3from
daniel-sanche:warm_improvements

Conversation

@daniel-sanche

@daniel-sanchedaniel-sanche commented Jun 22, 2023

Copy link
Copy Markdown
Contributor

Changes:

  • Previously, ping_and_warm was only warming an instance name. Now, rpcs are sent with proper app_profile_id and metadata fields for proper routing
    • to enable this, registered instances are stored in the client as an (instance_name, table_name, app_profile_id) namedtuple instead of just instance_name. Any time a table is created with a change in any of those fields, a new instance will be registered for warming on the client
  • changed _ping_and_warm_instance to allow warming channels for a single new instance, so all channels can be warmed for a new instance when added, without re-warming all existing instances
  • also, fixed metadata to use & as delimeter instead of ,

Fixes#809, #804

@daniel-sanche
daniel-sanche requested review from a teamJune 22, 2023 20:08
@product-auto-labelproduct-auto-labelBot added size: l Pull request size is large. api: bigtable Issues related to the googleapis/python-bigtable API. labels Jun 22, 2023
Comment threadgoogle/cloud/bigtable/client.py Outdated
@daniel-sanche
daniel-sanche merged commit ceaf598 into googleapis:v3Jun 26, 2023
daniel-sanche added a commit that referenced this pull request Feb 5, 2024
* feat: add new v3.0.0 API skeleton (#745)
* feat: improve rows filters (#751)
* feat: read rows query model class (#752)
* feat: implement row and cell model classes (#753)
* feat: add pooled grpc transport (#748)
* feat: implement read_rows (#762)
* feat: implement mutate rows (#769)
* feat: literal value filter (#767)
* feat: row_exists and read_row (#778)
* feat: read_modify_write and check_and_mutate_row (#780)
* feat: sharded read rows (#766)
* feat: ping and warm with metadata (#810)
* feat: mutate rows batching (#770)
* chore: restructure module paths (#816)
* feat: improve timeout structure (#819)
* fix: api errors apply to all bulk mutations
* chore: reduce public api surface (#820)
* feat: improve error group tracebacks on < py11 (#825)
* feat: optimize read_rows (#852)
* chore: add user agent suffix (#842)
* feat: optimize retries (#854)
* feat: add test proxy (#836)
* chore(tests): add conformance tests to CI for v3 (#870)
* chore(tests): turn off fast fail for conformance tets (#882)
* feat: add TABLE_DEFAULTS enum for table method arguments (#880)
* fix: pass None for retry in gapic calls (#881)
* feat: replace internal dictionaries with protos in gapic calls (#875)
* chore: optimize gapic calls (#863)
* feat: expose retryable error codes to users (#879)
* chore: update api_core submodule (#897)
* chore: merge main into experimental_v3 (#900)
* chore: pin conformance tests to v0.0.2 (#903)
* fix: bulk mutation eventual success (#909)
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigtableIssues related to the googleapis/python-bigtable API.size: lPull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@daniel-sanche@igorbernstein2