Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

feat: improve timeout structure - #819

Merged
daniel-sanche merged 227 commits into
googleapis:v3from
daniel-sanche:improve-timeouts
Jun 29, 2023
Merged

feat: improve timeout structure#819
daniel-sanche merged 227 commits into
googleapis:v3from
daniel-sanche:improve-timeouts

Conversation

@daniel-sanche

@daniel-sanchedaniel-sanche commented Jun 27, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor
  • renamed per_request_timeout to attempt_timeout
  • previously, we just had default_operation_timeout and default_per_request_timeout values configurable at the table level. Now, have different defaults for read_rows and mutate_rows
  • centralized timeout validation into a new helper function
  • improved some docstrings related to timeouts

Fixes#782

gcf-owl-botBotand others added 30 commits March 16, 2023 08:01
@gcf-owl-bot
chore(deps): Update nox in .kokoro/requirements.in [autoapprove] (goo…
748310b
…gleapis#750)
Source-Link: googleapis/synthtool@92006bb
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2e247c7bf5154df7f98cce087a20ca7605e236340c7d6d1a14447e5c06791bd6
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@gcf-owl-bot
docs: Fix formatting of request arg in docstring (googleapis#756)
45d3e43
* docs: Fix formatting of request arg in docstring
chore: Update gapic-generator-python to v1.9.1
PiperOrigin-RevId: 518604533
Source-Link: googleapis/googleapis@8a085ae
Source-Link: https://github.com/googleapis/googleapis-gen/commit/b2ab4b0a0ae2907e812c209198a74e0898afcb04
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@Mariatta
fix: Pass the "retry" when calling read_rows. (googleapis#759)
505273b
@shweta345
chore(samples): Fixed a typo in the readme (googleapis#760)
efe332c
@renovate-bot
chore(deps): update all dependencies (googleapis#746)
18b8f18
@billyjacobson
docs: fix delete from column family example (googleapis#764)
128b4e1
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigtable/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)
Fixes #<issue_number_goes_here> 🦕
@renovate-bot
chore(deps): update all dependencies (googleapis#763)
b5d10d6
@daniel-sanche
added initial implementation of mutate_rows
1d02154
@daniel-sanche
implemented mutation models
ab63cba
@daniel-sanche
added retries to mutate_row
cf9daa5
@daniel-sanche
return exception group if possible
1247da4
@daniel-sanche
check for idempotence
3b3ed8c
@daniel-sanche
initial implementation for bulk_mutations
5d20037
@daniel-sanche
include successes in bulk mutation error message
3d322a1
@daniel-sanche
fixed style checks
a31232b
@daniel-sanche
added basic system tests
8da2d65
@daniel-sanche
added unit tests for mutate_row
2b89d9c
@daniel-sanche
ran blacken
47c5985
@daniel-sanche
improved exceptions
38fdcd7
@daniel-sanche
added bulk_mutate_rows unit tests
504d2d8
@daniel-sanche
ran blacken
b16067f
@daniel-sanche
support __new___ for exceptions for python3.11+
3ab1405
@daniel-sanche
added exception unit tests
0a6c0c6
@daniel-sanche
makde exceptions tuple
ec043cf
@daniel-sanche
got exceptions to print consistently across versions
518530e
@daniel-sanche
added test for 311 rich traceback
9624729
@daniel-sanche
moved retryable row mutations to new file
3087081
@daniel-sanche
use index map
9df588f
@daniel-sanche
added docstring
7ed8be3
@daniel-sanche
added predicate check to failed mutations
2536cc4
@product-auto-labelproduct-auto-labelBot added size: xl Pull request size is extra large. api: bigtable Issues related to the googleapis/python-bigtable API. labels Jun 27, 2023
gcf-owl-botBotand others added 2 commits June 28, 2023 03:44
@gcf-owl-bot
chore: remove pinned Sphinx version [autoapprove] (googleapis#818)
eb55460
Source-Link: googleapis/synthtool@909573c
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ddf4551385d566771dc713090feb7b4c1164fb8a698fe52bbe7670b24236565b
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@daniel-sanche
Merge branch 'v3' into improve-timeouts
10d12b5
@product-auto-labelproduct-auto-labelBot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Jun 28, 2023
@daniel-sanchedaniel-sanche changed the title [DRAFT] feat: improve timeout structurefeat: improve timeout structureJun 28, 2023
@daniel-sanche
daniel-sanche marked this pull request as ready for review June 28, 2023 19:18
@daniel-sanche
daniel-sanche requested review from a teamJune 28, 2023 19:18
mutianf
mutianf reviewed Jun 28, 2023
View reviewed changes
Comment threadgoogle/cloud/bigtable/data/_async/_mutate_rows.py Outdated
Comment threadgoogle/cloud/bigtable/data/_async/_mutate_rows.py Outdated
Comment threadgoogle/cloud/bigtable/data/_async/client.py Outdated
Comment threadgoogle/cloud/bigtable/data/_async/client.py
Comment threadgoogle/cloud/bigtable/data/_async/client.py
Comment threadgoogle/cloud/bigtable/data/_async/mutations_batcher.py Outdated
Comment threadgoogle/cloud/bigtable/data/_async/mutations_batcher.py
Comment threadgoogle/cloud/bigtable/data/_async/mutations_batcher.py Outdated
daniel-sancheand others added 5 commits June 28, 2023 22:53
@daniel-sanche@mutianf
fix typo
639e9bb
Co-authored-by: Mattie Fu <mattiefu@google.com>
@daniel-sanche@mutianf
fix typo
bbb67c7
Co-authored-by: Mattie Fu <mattiefu@google.com>
@daniel-sanche
fixed docstring
b53bf48
@daniel-sanche
added default attempt timeout
1e4366e
@daniel-sanche
removed attempt <= operation limit
9f772d8
igorbernstein2
igorbernstein2 reviewed Jun 29, 2023
View reviewed changes
Comment threadgoogle/cloud/bigtable/data/_async/client.py
igorbernstein2
igorbernstein2 reviewed Jun 29, 2023
View reviewed changes
Comment threadgoogle/cloud/bigtable/data/_async/client.py
igorbernstein2
igorbernstein2 reviewed Jun 29, 2023
View reviewed changes
Comment threadgoogle/cloud/bigtable/data/_async/client.py
@daniel-sanche
daniel-sanche merged commit 07438ca into googleapis:v3Jun 29, 2023
daniel-sanche added a commit that referenced this pull request Feb 5, 2024
@daniel-sanche@gcf-owl-bot
chore: add experimental async data client (#920)
7088e39
* feat: add new v3.0.0 API skeleton (#745)
* feat: improve rows filters (#751)
* feat: read rows query model class (#752)
* feat: implement row and cell model classes (#753)
* feat: add pooled grpc transport (#748)
* feat: implement read_rows (#762)
* feat: implement mutate rows (#769)
* feat: literal value filter (#767)
* feat: row_exists and read_row (#778)
* feat: read_modify_write and check_and_mutate_row (#780)
* feat: sharded read rows (#766)
* feat: ping and warm with metadata (#810)
* feat: mutate rows batching (#770)
* chore: restructure module paths (#816)
* feat: improve timeout structure (#819)
* fix: api errors apply to all bulk mutations
* chore: reduce public api surface (#820)
* feat: improve error group tracebacks on < py11 (#825)
* feat: optimize read_rows (#852)
* chore: add user agent suffix (#842)
* feat: optimize retries (#854)
* feat: add test proxy (#836)
* chore(tests): add conformance tests to CI for v3 (#870)
* chore(tests): turn off fast fail for conformance tets (#882)
* feat: add TABLE_DEFAULTS enum for table method arguments (#880)
* fix: pass None for retry in gapic calls (#881)
* feat: replace internal dictionaries with protos in gapic calls (#875)
* chore: optimize gapic calls (#863)
* feat: expose retryable error codes to users (#879)
* chore: update api_core submodule (#897)
* chore: merge main into experimental_v3 (#900)
* chore: pin conformance tests to v0.0.2 (#903)
* fix: bulk mutation eventual success (#909)
---------
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@mutianfmutianfmutianf left review comments
@igorbernstein2igorbernstein2igorbernstein2 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtableIssues related to the googleapis/python-bigtable API.size: lPull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@daniel-sanche@mutianf@igorbernstein2@Mariatta@shweta345@renovate-bot@billyjacobson@Sita04