Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.

Key property fix - #242

Closed
epluntze wants to merge 2 commits into
googleapis:masterfrom
sandboxxapp:key_property_fix
Closed

Key property fix#242
epluntze wants to merge 2 commits into
googleapis:masterfrom
sandboxxapp:key_property_fix

Conversation

@epluntze

Copy link
Copy Markdown

Looks like Key properties were trying to assign the name of a property to the Kind when passing the Kind as a string. This prevented multiple Key properties of the same kind on the same model from being saved

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 14, 2019
@chrisrossi

Copy link
Copy Markdown
Contributor

Thanks @epluntze for this nudge in the right direction.

The problem is trying to maintain this overly complicated method signature in a way that's compatible with Python 2 and Python 3 and the ultimate fix is a little more complex. See #243

Thanks!

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@epluntze@chrisrossi@googlebot