Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on May 6, 2026. It is now read-only.
Fix argument handling for KeyProperty constructor. - #243
Merged
Conversation
The changes for Python 2.7 compatibility broke the constructor for KeyProperty, making it so you could no longer pass in a string for the `kind` argument as a keyword. This reverts back to something more like what was used in the original version of NDB, but preserving the documented method signature. I'm not a huge fan of this style of argument handling. (Maybe the first argument is `name`, or maybe it's `kind`, let's figure it out!) But I guess we're stuck with for backwards compatibility. Thanks to @epluntze for pointing me in the right direction. Fixesgoogleapis#240.
Closed
cguardia
approved these changes
Nov 16, 2019
cguardia
left a comment
Contributor
There was a problem hiding this comment.
Thanks. This was one of the changes that I wasn't very happy about, so it's great that you fixed it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes for Python 2.7 compatibility broke the constructor for
KeyProperty, making it so you could no longer pass in a string for the
kindargument as a keyword. This reverts back to something more likewhat was used in the original version of NDB, but preserving the
documented method signature.
I'm not a huge fan of this style of argument handling. (Maybe the first
argument is
name, or maybe it'skind, let's figure it out!) But Iguess we're stuck with it for backwards compatibility.
Thanks to @epluntze for pointing me in the right direction.
Fixes#240.