Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

refactor: incorporate will_accept() checks into publish() - #108

Merged
pradn merged 6 commits into
googleapis:masterfrom
MaxxleLLC:erase_will_accept_method
Jun 9, 2020
Merged

refactor: incorporate will_accept() checks into publish()#108
pradn merged 6 commits into
googleapis:masterfrom
MaxxleLLC:erase_will_accept_method

Conversation

@IlyaFaer

@IlyaFaerIlyaFaer commented May 28, 2020

Copy link
Copy Markdown

Closes#105

@IlyaFaerIlyaFaer added api: pubsub Issues related to the googleapis/python-pubsub API. type: cleanup An internal cleanup or hygiene concern. labels May 28, 2020
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label May 28, 2020
IlyaFaer
IlyaFaer commented May 28, 2020
View reviewed changes
Comment threadgoogle/cloud/pubsub_v1/publisher/_batch/base.py
@IlyaFaer
IlyaFaer requested a review from pradnMay 28, 2020 10:56
@IlyaFaer
IlyaFaer marked this pull request as ready for review May 28, 2020 10:56
pradn
pradn suggested changes May 28, 2020
View reviewed changes

@pradnpradn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on! I think we need to retain/add some tests. Otherwise, looks good.

Comment threadtests/unit/pubsub_v1/publisher/batch/test_base.py
Comment threadtests/unit/pubsub_v1/publisher/batch/test_thread.py
pradn
pradn suggested changes Jun 5, 2020
View reviewed changes
Comment threadtests/unit/pubsub_v1/publisher/batch/test_thread.py
pradn
pradn approved these changes Jun 5, 2020
View reviewed changes

@pradnpradn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good!

@pradnpradn added the automerge Merge the pull request once unit tests and other checks pass. label Jun 9, 2020
@gcf-merge-on-green

gcf-merge-on-greenBot commented Jun 9, 2020

Copy link
Copy Markdown

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green

gcf-merge-on-greenBot commented Jun 9, 2020

Copy link
Copy Markdown

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@meredithslota
meredithslota requested a review from plamutJune 9, 2020 20:53
@pradn
pradn merged commit 6c7677e into googleapis:masterJun 9, 2020
@pradn

pradn commented Jun 9, 2020

Copy link
Copy Markdown
Contributor

Thanks @IlyaFaer !

@pradnpradn mentioned this pull request Jun 9, 2020
Closed
@release-pleaserelease-pleaseBot mentioned this pull request Jun 9, 2020
Merged
gcf-merge-on-greenBot pushed a commit that referenced this pull request Jun 9, 2020
@release-please
chore: release 1.6.0 (#117)
60fe71a
## [1.6.0](https://www.github.com/googleapis/python-pubsub/compare/v1.5.0...v1.6.0) (2020-06-09)
### Features
* Add flow control for message publishing ([#96](https://www.github.com/googleapis/python-pubsub/issues/96)) ([06085c4](https://www.github.com/googleapis/python-pubsub/commit/06085c4083b9dccdd50383257799904510bbf3a0))
### Bug Fixes
* Fix PubSub incompatibility with api-core 1.17.0+ ([#103](https://www.github.com/googleapis/python-pubsub/issues/103)) ([c02060f](https://www.github.com/googleapis/python-pubsub/commit/c02060fbbe6e2ca4664bee08d2de10665d41dc0b))
### Documentation
- Clarify that Schedulers shouldn't be used with multiple SubscriberClients ([#100](#100)) ([cf9e87c](cf9e87c))
- Fix update subscription/snapshot/topic samples ([#113](#113)) ([e62c38b](e62c38b))
### Internal / Testing Changes
- Re-generated service implementaton using synth: removed experimental notes from the RetryPolicy and filtering features in anticipation of GA, added DetachSubscription (experimental) ([#114](#114)) ([0132a46](0132a46))
- Incorporate will_accept() checks into publish() ([#108](#108)) ([6c7677e](6c7677e))
@IlyaFaer
IlyaFaer deleted the erase_will_accept_method branch June 10, 2020 07:26
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Mar 2, 2026
@release-please
chore: release 1.6.0 (#117)
61e2b02
## [1.6.0](https://www.github.com/googleapis/python-pubsub/compare/v1.5.0...v1.6.0) (2020-06-09)
### Features
* Add flow control for message publishing ([#96](https://www.github.com/googleapis/python-pubsub/issues/96)) ([06085c4](https://www.github.com/googleapis/python-pubsub/commit/06085c4083b9dccdd50383257799904510bbf3a0))
### Bug Fixes
* Fix PubSub incompatibility with api-core 1.17.0+ ([#103](https://www.github.com/googleapis/python-pubsub/issues/103)) ([c02060f](https://www.github.com/googleapis/python-pubsub/commit/c02060fbbe6e2ca4664bee08d2de10665d41dc0b))
### Documentation
- Clarify that Schedulers shouldn't be used with multiple SubscriberClients ([#100](googleapis/python-pubsub#100)) ([cf9e87c](googleapis/python-pubsub@cf9e87c))
- Fix update subscription/snapshot/topic samples ([#113](googleapis/python-pubsub#113)) ([e62c38b](googleapis/python-pubsub@e62c38b))
### Internal / Testing Changes
- Re-generated service implementaton using synth: removed experimental notes from the RetryPolicy and filtering features in anticipation of GA, added DetachSubscription (experimental) ([#114](googleapis/python-pubsub#114)) ([0132a46](googleapis/python-pubsub@0132a46))
- Incorporate will_accept() checks into publish() ([#108](googleapis/python-pubsub#108)) ([6c7677e](googleapis/python-pubsub@6c7677e))
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@plamutplamutAwaiting requested review from plamut
1 more reviewer
@pradnpradnpradn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsubIssues related to the googleapis/python-pubsub API.automergeMerge the pull request once unit tests and other checks pass.cla: yesThis human has signed the Contributor License Agreement.type: cleanupAn internal cleanup or hygiene concern.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

unused message arg in Batch.will_accept()

4 participants

@IlyaFaer@pradn@plamut@googlebot