Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

chore: release 1.6.0 - #117

Merged
gcf-merge-on-green[bot] merged 5 commits into
masterfrom
release-v1.6.0
Jun 9, 2020
Merged

chore: release 1.6.0#117
gcf-merge-on-green[bot] merged 5 commits into
masterfrom
release-v1.6.0

Conversation

@release-please

@release-pleaserelease-pleaseBot commented Jun 9, 2020

Copy link
Copy Markdown
Contributor

1.6.0 (2020-06-09)

Features

  • Add flow control for message publishing (#96) (06085c4)

Bug Fixes

  • Fix PubSub incompatibility with api-core 1.17.0+ (#103) (c02060f)

Documentation

  • Clarify that Schedulers shouldn't be used with multiple SubscriberClients (#100) (cf9e87c)
  • Fix update subscription/snapshot/topic samples (#113) (e62c38b)

Internal / Testing Changes

  • Re-generated service implementaton using synth: removed experimental notes from the RetryPolicy and filtering features in anticipation of GA, added DetachSubscription (experimental) (#114) (0132a46)
  • Incorporate will_accept() checks into publish() (#108) (6c7677e)

@trusted-contributions-gcftrusted-contributions-gcfBot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 9, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
@plamut
plamut requested a review from pradnJune 9, 2020 22:27

@plamutplamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, where is #108?

Answer: The bot did not recognize the type of that PR and did not include it in the release notes, we will edit them manually.

Update: Actually, the bot only included 2 of the 6 commits added since the 1.5.0 release...

@trusted-contributions-gcftrusted-contributions-gcfBot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
@trusted-contributions-gcftrusted-contributions-gcfBot added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020

@plamutplamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update a few URLs...

Comment threadCHANGELOG.md Outdated
@yoshi-kokoroyoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 9, 2020
@plamutplamut added the automerge Merge the pull request once unit tests and other checks pass. label Jun 9, 2020
@gcf-merge-on-green
gcf-merge-on-greenBot merged commit 60fe71a into masterJun 9, 2020
@yoshi-automation

Copy link
Copy Markdown
Contributor

@busunkim96

Copy link
Copy Markdown
Contributor

@plamut The bot is configured to only add commits of type fix and feat to the changelog. If we want additional types, we can modify the logic.

@plamut

Copy link
Copy Markdown
Contributor

@busunkim96 That would make sense, probably at least docs should be easy to classify.

Maybe adding a note / warning to the PR description would also be helpful to remind reviewers that CHANGELOG might not include all the commits and should be double-checked?

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automergeMerge the pull request once unit tests and other checks pass.autorelease: taggedcla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@yoshi-automation@busunkim96@plamut@pradn@googlebot@yoshi-kokoro