Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

feat: resumable media integration - #1283

Merged
andrewsg merged 5 commits into
resumable-mediafrom
resumable-media-integration
Jul 8, 2024
Merged

feat: resumable media integration#1283
andrewsg merged 5 commits into
resumable-mediafrom
resumable-media-integration

Conversation

@andrewsg

@andrewsgandrewsg commented May 31, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

This merges the "resumable media integration" project into a separate base branch. The base branch is designed to produce a readable diff for this PR. The only change to the base branch from main is copying the resumable media library into this library, in the correct directory/module structure, without further modification.

@andrewsgandrewsg added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 31, 2024
@andrewsg
andrewsg requested review from a teamMay 31, 2024 19:04
@product-auto-labelproduct-auto-labelBot added the size: xl Pull request size is extra large. label May 31, 2024
@product-auto-labelproduct-auto-labelBot added the api: storage Issues related to the googleapis/python-storage API. label May 31, 2024
@danielduhh
danielduhh requested a review from cojencoJune 17, 2024 21:44
@andrewsg
andrewsgforce-pushed the resumable-media-integration branch from 5797001 to fdfcff9CompareJune 24, 2024 20:12
@andrewsg
andrewsg requested a review from a team as a code ownerJune 24, 2024 20:12
@andrewsg
andrewsg requested review from iennae and removed request for a teamJune 24, 2024 20:12
@snippet-bot

snippet-botBot commented Jun 24, 2024•
edited
Loading

Copy link
Copy Markdown

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@andrewsg
andrewsg changed the base branch from 3.0-devel to resumable-mediaJune 24, 2024 20:18
@conventional-commit-lint-gcf

conventional-commit-lint-gcfBot commented Jun 24, 2024•
edited
Loading

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@andrewsg
andrewsg removed the request for review from iennaeJune 24, 2024 20:18
@andrewsgandrewsg changed the title Resumable media integrationfeat: resumable media integrationJun 24, 2024
@andrewsgandrewsg assigned cojenco and unassigned BrennaEppJun 25, 2024
@andrewsg
integrate resumable media
aad4e11
update from base branch
@andrewsg
andrewsgforce-pushed the resumable-media-integration branch from fdfcff9 to aad4e11CompareJune 26, 2024 15:56
@product-auto-labelproduct-auto-labelBot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Jun 26, 2024
cojenco
cojenco reviewed Jun 27, 2024
View reviewed changes
Comment threadnoxfile.py
Comment threadgoogle/cloud/storage/_media/common.py
Comment threadgoogle/cloud/storage/exceptions.py
Comment threadgoogle/cloud/storage/_media/requests/_request_helpers.py
Comment threadgoogle/cloud/storage/exceptions.py Outdated
Comment threadgoogle/cloud/storage/_helpers.py
andrewsgand others added 2 commits July 8, 2024 10:06
@andrewsg@cojenco
Update google/cloud/storage/exceptions.py
eb95d97
Co-authored-by: cojenco <cathyo@google.com>
@andrewsg
update docs
273b3a8
@andrewsgandrewsg removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 8, 2024
cojenco
cojenco approved these changes Jul 8, 2024
View reviewed changes

@cojencocojenco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@andrewsg
andrewsg merged commit 1c7caca into resumable-mediaJul 8, 2024
@andrewsg
andrewsg deleted the resumable-media-integration branch July 8, 2024 17:49
andrewsg added a commit that referenced this pull request Dec 5, 2024
@andrewsg@cojenco
feat: resumable media integration (#1283)
5bf75af
Integrate the google-resumable-media library into python-storage.
---------
Co-authored-by: cojenco <cathyo@google.com>
@cojencocojenco mentioned this pull request Dec 9, 2024
Merged
andrewsg added a commit that referenced this pull request Dec 10, 2024
@andrewsg@cojenco
feat: resumable media integration (#1283)
546969c
Integrate the google-resumable-media library into python-storage.
---------
Co-authored-by: cojenco <cathyo@google.com>
andrewsg added a commit that referenced this pull request Dec 10, 2024
@andrewsg@cojenco
feat: Integrate google-resumable-media (#1283)
261fc2b
Integrate the google-resumable-media library into python-storage.
---------
Co-authored-by: cojenco <cathyo@google.com>
andrewsg added a commit that referenced this pull request Dec 11, 2024
@andrewsg@cojenco
feat: Integrate google-resumable-media (#1283)
bd917b4
Integrate the google-resumable-media library into python-storage.
---------
Co-authored-by: cojenco <cathyo@google.com>
@release-pleaserelease-pleaseBot mentioned this pull request Dec 11, 2024
Merged
cojenco added a commit to cojenco/python-storage that referenced this pull request May 22, 2025
@cojenco
update expections as pergoogleapis#1283
238bacf
@cojencocojenco mentioned this pull request May 22, 2025
Merged
cojenco added a commit that referenced this pull request May 28, 2025
@cojenco
fix: add a check for partial response data (#1487)
7e0412a
* fix: import googleapis/google-resumable-media-python#435
* update expections as per #1283
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Mar 9, 2026
@cojenco
fix: add a check for partial response data (#1487)
cf55ddb
* fix: import googleapis/google-resumable-media-python#435
* update expections as per googleapis/python-storage#1283
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@cojencocojencocojenco approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@cojencocojenco

Labels

api: storageIssues related to the googleapis/python-storage API.size: lPull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewsg@cojenco@BrennaEpp