Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

feat: Integrate google-resumable-media (#1283) - #1389

Merged
andrewsg merged 1 commit into
3.0-prefrom
3.0-pre-resumable-media-integration
Dec 10, 2024
Merged

feat: Integrate google-resumable-media (#1283)#1389
andrewsg merged 1 commit into
3.0-prefrom
3.0-pre-resumable-media-integration

Conversation

@andrewsg

@andrewsgandrewsg commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

Integrate the google-resumable-media library into python-storage.

This branch, 3.0-pre, will reconstruct the 3.0-devel branch rebased on top of the most HEAD in main, in preparation for an imminent preview release.

This PR intentionally separates out and skips the intermediate commit move resumable media files into branch without other changes in order to provide a useful diff.

Due to the development process for the 3.0 branch, this PR is being reviewed belatedly as further changes are already integrated on the 3.0-devel branch.

BEGIN_COMMIT_OVERRIDE
feat!: Integrate google-resumable-media
END_COMMIT_OVERRIDE

Integrate the google-resumable-media library into python-storage.
---------
Co-authored-by: cojenco <cathyo@google.com>
@andrewsg
andrewsg requested review from a teamDecember 5, 2024 01:54
@product-auto-labelproduct-auto-labelBot added size: l Pull request size is large. api: storage Issues related to the googleapis/python-storage API. labels Dec 5, 2024
@andrewsgandrewsg changed the title feat: resumable media integration (#1283)feat: Integrate google-resumable-media (#1283)Dec 5, 2024
Comment threadtests/resumable_media/unit/requests/test_download.py
@ddelgrosso1

Copy link
Copy Markdown
Contributor

No real comments as this looks like mainly a large refactor to move media internal. Most changes look like just updates to pathing / imports.

@cojencocojenco left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM questions and reviews were addressed in #1283

The failed kokoro should be fixed via d17a15d

@andrewsg

Copy link
Copy Markdown
ContributorAuthor

Oh I forgot about our earlier review, thanks for reminding me. Okay, I'll merge this and also the later fixes.

@andrewsg
andrewsg merged commit 546969c into 3.0-preDec 10, 2024
@andrewsg
andrewsg deleted the 3.0-pre-resumable-media-integration branch December 10, 2024 00:07
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storageIssues related to the googleapis/python-storage API.size: lPull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewsg@ddelgrosso1@cojenco