Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

fix: add requests as a dependency - #271

Merged
plamut merged 2 commits into
googleapis:masterfrom
MaxxleLLC:storage_issue_268
Sep 16, 2020
Merged

fix: add requests as a dependency#271
plamut merged 2 commits into
googleapis:masterfrom
MaxxleLLC:storage_issue_268

Conversation

@HemangChothani

Copy link
Copy Markdown
Contributor

Fixes#268

@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Sep 15, 2020
@product-auto-labelproduct-auto-labelBot added the api: storage Issues related to the googleapis/python-storage API. label Sep 15, 2020
@HemangChothaniHemangChothani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 15, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 15, 2020

@andrewsgandrewsg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to submit this.

@andrewsg

Copy link
Copy Markdown
Contributor

Build error looks unrelated at first glance, but we need to investigate before merging

@HemangChothani

Copy link
Copy Markdown
ContributorAuthor

System test issue will be fixed by PR #273

@plamutplamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 16, 2020
@yoshi-kokoroyoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 16, 2020
@plamut

Copy link
Copy Markdown
Contributor

Restricting the PubSub version to <2.0.0 indeed helped, system tests now pass again.

@plamut
plamut merged commit ec52b38 into googleapis:masterSep 16, 2020
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Co-authored-by: Peter Lamut <plamut@users.noreply.github.com>
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Co-authored-by: Peter Lamut <plamut@users.noreply.github.com>
@release-pleaserelease-pleaseBot mentioned this pull request Jan 12, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storageIssues related to the googleapis/python-storage API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

requests is missing as dependency

4 participants

@HemangChothani@andrewsg@plamut@yoshi-kokoro