Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

chore: restrict pubsub to < 2.0 - #273

Merged
plamut merged 1 commit into
googleapis:masterfrom
MaxxleLLC:storage_issue_272
Sep 16, 2020
Merged

chore: restrict pubsub to < 2.0#273
plamut merged 1 commit into
googleapis:masterfrom
MaxxleLLC:storage_issue_272

Conversation

@HemangChothani

Copy link
Copy Markdown
Contributor

Fixes#272

For the passing current scenario restrict version in nox.py file and for the future added in synth.py file.

google-cloud-pubsub==2.0.0 version has dropped the support of python2, so once storage will drop the support following changes needs to be done:

  • replace create_topic(self.topic_path) to create_topic(name=self.topic_path)

  • replace get_iam_policy(self.topic_path) to get_iam_policy(request={"resource": self.topic_path})

  • replace set_iam_policy(self.topic_path, policy) to set_iam_policy(request={"resource": self.topic_path, "policy": policy})

  • replace delete_topic(self.topic_path) to delete_topic(request={"topic":self.topic_path})

@google-clagoogle-claBot added the cla: yes This human has signed the Contributor License Agreement. label Sep 16, 2020
@product-auto-labelproduct-auto-labelBot added the api: storage Issues related to the googleapis/python-storage API. label Sep 16, 2020

@plamutplamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, the dependency should indeed be pinned to exclude the next major version, as major versions are generally expected to contain breaking changes.

@plamut
plamut merged commit 0642a73 into googleapis:masterSep 16, 2020
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storageIssues related to the googleapis/python-storage API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System test failed for python3.8

2 participants

@HemangChothani@plamut