Skip to content
This repository was archived by the owner on Feb 23, 2024. It is now read-only.

fix(deps): require google-api-core >= 1.31.5, >= 2.3.2 on v2 release - #353

Merged
parthea merged 7 commits into
v2from
v2-api-core-pin
Apr 5, 2022
Merged

fix(deps): require google-api-core >= 1.31.5, >= 2.3.2 on v2 release#353
parthea merged 7 commits into
v2from
v2-api-core-pin

Conversation

@busunkim96

Copy link
Copy Markdown
Contributor

Allow google-api-core<3.0.0dev on previous release of library. Note that this PR is to a new protected branch v2, not main.

This will be followed by a release PR and is a step towards removing googleapis/google-cloud-python#10566

@busunkim96
busunkim96 requested a review from partheaMarch 11, 2022 02:03
@product-auto-labelproduct-auto-labelBot added the api: translate Issues related to the googleapis/python-translate API. label Mar 11, 2022
`google-cloud-core` version 1.4.2 populates `prettyPrint=false` by
default. Update the connection tests to expect a value for
`prettyPrint`.
Comment threadsetup.py Outdated
@partheaparthea changed the title chore(deps): allow google-api-core v2 on v2 releasefix(deps): require google-api-core >= 1.31.5, >= 2.3.2 on v2 releaseMar 14, 2022
@busunkim96

Copy link
Copy Markdown
ContributorAuthor

@parthea Friendly ping!

@parthea
parthea merged commit 2e4874c into v2Apr 5, 2022
@parthea
parthea deleted the v2-api-core-pin branch April 5, 2022 17:12
@release-pleaserelease-pleaseBot mentioned this pull request Apr 5, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: translateIssues related to the googleapis/python-translate API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@busunkim96@parthea@tswast