Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Feb 23, 2024. It is now read-only.
test: update tests to support latest google-cloud-core - #69
Merged
Conversation
`google-cloud-core` version 1.4.2 populates `prettyPrint=false` by default. Update the connection tests to expect a value for `prettyPrint`.
tseaver
approved these changes
Oct 6, 2020
parthea pushed a commit
that referenced
this pull request
Mar 12, 2022
`google-cloud-core` version 1.4.2 populates `prettyPrint=false` by default. Update the connection tests to expect a value for `prettyPrint`.
parthea added a commit
that referenced
this pull request
Apr 5, 2022
…353) * chore(deps): allow google-api-core v2 on v2 release * test: update tests to support latest google-cloud-core (#69) `google-cloud-core` version 1.4.2 populates `prettyPrint=false` by default. Update the connection tests to expect a value for `prettyPrint`. * ci: fix docs build * chore: lint * Update setup.py Co-authored-by: Anthonios Partheniou <partheniou@google.com> * chore: format, revert changes to tests Co-authored-by: Tim Swast <swast@google.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
google-cloud-coreversion 1.4.2 populatesprettyPrint=falsebydefault. Update the connection tests to expect a value for
prettyPrint.test_build_api_url_w_extra_query_params_tupleunit test is currently failing, but will be fixed by googleapis/python-cloud-core#34This pull request is to check that the changes made in googleapis/python-cloud-core#28 do not break this library.