feat(library): add Star-Spangled Banner + Ode to Joy starter content

[byrongamatos]

Adds two more public-domain starter songs alongside Für Elise, wired into _BUILTIN_STARTER_SOURCES so they seed into DLC_DIR/starter/ on first run.

Songs

Song	Arrangements	Author	Size
The Star-Spangled Banner	Lead	Fee[dB]ack	3.5 MB
Ode to Joy	Lead / Rhythm / Bass + drums	Fee[dB]ack	1.7 MB

• Star-Spangled Banner: cleaned the Unknown artist / placeholder album (John Stafford Smith, The Anacreontic Song, 1814).
• Ode to Joy: replaces the raw Ode to Joy (VST Cover)_The Adicts.feedpak that was committed to main but never added to the seed list — so it bundled 23 MB of dead weight into every build and never appeared. Fixed metadata (artist Beethoven, year 1824, author Fee[dB]ack) and repointed the stem from the 22 MB editor WAV to the byte-identical-render full.ogg (both exactly 85.324 s, so the chart stays aligned), shrinking the pack 23.8 MB → 1.7 MB.

Guards

New tests assert (a) every listed source is present on disk and seeds, and (b) no on-disk content/starter/*.feedpak is unlisted — the exact list↔file mismatch that left Ode to Joy un-seeded. All 3 packs verified to load through the app's extract_meta.

No seeding-code changes; no desktop change needed (the bundler already globs content/starter/*.feedpak). Codex preflight: clean.

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Added two more bundled starter songs that are included in first-time DLC setup.
  • Starter content now seeds a broader set of built-in packs when creating a fresh DLC.

• Tests

  • Added checks to ensure all bundled starter packs have matching committed files.
  • Added coverage confirming all listed starter packs seed correctly on a clean setup.
  • Added a guard against extra starter packs that would not be included in seeding.

[coderabbitai]

📝 Walkthrough

Walkthrough

Two new starter .feedpak entries (star_spangled_banner and beethoven-ode_to_joy) are added to the built-in DLC starter seed source list. New tests verify each declared source file exists on disk, seeding copies all listed packs with a marker file, and no unlisted packs exist under content/starter/.

Changes

Starter Pack Seeding Update

Layer / File(s)	Summary
New starter pack sources server.py	Adds two entries (star_spangled_banner.feedpak, beethoven-ode_to_joy.feedpak) to _BUILTIN_STARTER_SOURCES.
Seeding validation tests tests/test_builtin_starter_seed.py	Adds tests checking declared source files exist, seeding copies all listed packs and writes the marker, and no unlisted .feedpak files exist under content/starter/.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	Title matches the main change: adding Star-Spangled Banner and Ode to Joy starter content to the library.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/starter-content-anthem

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

tests/test_builtin_starter_seed.py (1)

216-234: 🎯 Functional Correctness | 🔵 Trivial | 💤 Low value

Directory derivation assumes a single shared starter directory.

content_dir is derived from the parent of an arbitrary listed entry (next(iter(listed))). If a future _BUILTIN_STARTER_SOURCES entry lives under a different directory, this test only globs one directory and would silently miss unlisted packs elsewhere — exactly the class of bug this guard test is meant to catch.

Since the test already documents this assumption ("all sources share this dir"), this is low priority but worth hardening by grouping listed sources by parent directory and globbing each.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/test_builtin_starter_seed.py` around lines 216 - 234, The starter-pack
guard test assumes all entries in _BUILTIN_STARTER_SOURCES share one parent
directory, so it can miss stray .feedpak files if that assumption changes.
Update test_no_unlisted_starter_pack_on_disk to derive content directories from
each listed starter source in server_mod._BUILTIN_STARTER_SOURCES, group them by
parent, and glob *.feedpak in every relevant directory instead of using
next(iter(listed)); keep the existing unlisted assertion logic unchanged.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@tests/test_builtin_starter_seed.py`:
- Around line 216-234: The starter-pack guard test assumes all entries in
_BUILTIN_STARTER_SOURCES share one parent directory, so it can miss stray
.feedpak files if that assumption changes. Update
test_no_unlisted_starter_pack_on_disk to derive content directories from each
listed starter source in server_mod._BUILTIN_STARTER_SOURCES, group them by
parent, and glob *.feedpak in every relevant directory instead of using
next(iter(listed)); keep the existing unlisted assertion logic unchanged.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 86f9ad71-d11c-4956-9094-c8654a3b6e5d

📥 Commits

Reviewing files that changed from the base of the PR and between 6ab1ed9 and 74c4f16.

📒 Files selected for processing (5)

• content/starter/Ode to Joy (VST Cover)_The Adicts.feedpak
• content/starter/beethoven-ode_to_joy.feedpak
• content/starter/star_spangled_banner.feedpak
• server.py
• tests/test_builtin_starter_seed.py

[Copilot]

Pull request overview

Adds two additional bundled, public-domain starter song packs and ensures they are correctly wired into the one-time seeding mechanism so they appear in DLC_DIR/starter/ on first run, while preventing “bundled but unseeded” starter content regressions.

Changes:

• Extend _BUILTIN_STARTER_SOURCES to include Star-Spangled Banner and Ode to Joy starter packs.
• Add test guards to ensure _BUILTIN_STARTER_SOURCES and on-disk content/starter/*.feedpak stay in sync, and that seeding lands every listed pack.

Reviewed changes

Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.

File	Description
server.py	Adds the two new starter packs to _BUILTIN_STARTER_SOURCES so they seed on first run.
tests/test_builtin_starter_seed.py	Adds coverage to prevent listed↔on-disk mismatches and to validate all listed packs seed successfully.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.