fix(starter): re-sync _BUILTIN_STARTER_SOURCES with content/starter on disk - #775
Conversation
Two commits (delete beethoven-ode_to_joy, re-add The Adicts' Ode to Joy) never updated _BUILTIN_STARTER_SOURCES: it still listed the deleted pack and omitted the added one. The listed-but-missing file made the all-present gate never fire, so NO starter content seeded on first run — and the on-disk-but-unlisted pack would bundle as dead weight. Both starter-seed guard tests were red on main, reddening ci/test on every core PR. Sync the manifest to disk. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe bundled starter-content source list in server.py is updated to replace a reference to a deleted Beethoven "Ode to Joy" feedpak with an existing "The Adicts" feedpak entry and its content path. CHANGELOG.md documents this fix under Unreleased. ChangesStarter content feedpak fix
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR re-syncs the server’s built-in starter-pack manifest with the actual content/starter/ files on disk so first-run starter seeding works again (and CI guard tests stop failing).
Changes:
- Update
_BUILTIN_STARTER_SOURCESto remove the deletedbeethoven-ode_to_joy.feedpakentry and addthe_adicts-ode-to-joy_vst_cover.feedpak. - Add a changelog entry documenting the restored starter seeding and the manifest/disk mismatch root cause.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
server.py |
Updates the starter-pack source manifest to match content/starter/*.feedpak, restoring starter seeding behavior. |
CHANGELOG.md |
Documents the starter seeding fix and the newly-shipped starter pack entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Problem
The 6
tests/test_builtin_starter_seed.pytests are red onmain(ci / testfails on every core PR as a result).Cause
Two commits landed on
mainwithout updating the manifest:a3f1bcere-addedcontent/starter/the_adicts-ode-to-joy_vst_cover.feedpakto disk — but never listed it in_BUILTIN_STARTER_SOURCES.b6169afdeletedcontent/starter/beethoven-ode_to_joy.feedpakfrom disk — but left its entry in_BUILTIN_STARTER_SOURCES.So the list has a listed-but-missing file and the disk has an unlisted file:
test_every_starter_source_file_is_present→ red (beethoven-ode_to_joy listed, not on disk)test_no_unlisted_starter_pack_on_disk→ red (the_adicts on disk, not listed)User impact: a listed-but-missing pack makes the all-present gate never fire, so no starter songs seed on first run — starter content is currently broken on
main, not just the tests.Fix
Sync
_BUILTIN_STARTER_SOURCESto what's on disk: Für Elise, Star Spangled Banner, and The Adicts' Ode to Joy (replacing the deleted beethoven-ode_to_joy entry). No binary/content changes — the packs are already committed.Tests
tests/test_builtin_starter_seed.py→ 12 passed (both guard tests green).🤖 Generated with Claude Code
Summary by CodeRabbit