Skip to content

fix(starter): re-sync _BUILTIN_STARTER_SOURCES with content/starter on disk - #775

Merged
byrongamatos merged 1 commit into
mainfrom
fix/starter-content-sources
Jul 4, 2026
Merged

byrongamatos merged 1 commit into
mainfrom
fix/starter-content-sources

Conversation

@byrongamatos

@byrongamatos byrongamatos commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Problem

The 6 tests/test_builtin_starter_seed.py tests are red on main (ci / test fails on every core PR as a result).

Cause

Two commits landed on main without updating the manifest:

  • a3f1bce re-added content/starter/the_adicts-ode-to-joy_vst_cover.feedpak to disk — but never listed it in _BUILTIN_STARTER_SOURCES.
  • b6169af deleted content/starter/beethoven-ode_to_joy.feedpak from disk — but left its entry in _BUILTIN_STARTER_SOURCES.

So the list has a listed-but-missing file and the disk has an unlisted file:

  • test_every_starter_source_file_is_present → red (beethoven-ode_to_joy listed, not on disk)
  • test_no_unlisted_starter_pack_on_disk → red (the_adicts on disk, not listed)

User impact: a listed-but-missing pack makes the all-present gate never fire, so no starter songs seed on first run — starter content is currently broken on main, not just the tests.

Fix

Sync _BUILTIN_STARTER_SOURCES to what's on disk: Für Elise, Star Spangled Banner, and The Adicts' Ode to Joy (replacing the deleted beethoven-ode_to_joy entry). No binary/content changes — the packs are already committed.

Tests

tests/test_builtin_starter_seed.py12 passed (both guard tests green).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Fixed starter content seeding on first run by correcting the bundled starter pack selection.
    • Fresh installs now seed the intended starter content instead of failing due to a missing packaged item.
    • Updated the release notes to reflect the restored starter content behavior.

Two commits (delete beethoven-ode_to_joy, re-add The Adicts' Ode to Joy) never
updated _BUILTIN_STARTER_SOURCES: it still listed the deleted pack and omitted
the added one. The listed-but-missing file made the all-present gate never fire,
so NO starter content seeded on first run — and the on-disk-but-unlisted pack
would bundle as dead weight. Both starter-seed guard tests were red on main,
reddening ci/test on every core PR. Sync the manifest to disk.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 4, 2026 21:54
@coderabbitai

coderabbitai Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1cfb160f-4fa6-42b7-97f2-aeaa950b9b86

📥 Commits

Reviewing files that changed from the base of the PR and between b6169af and 3d989a1.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • server.py

📝 Walkthrough

Walkthrough

The bundled starter-content source list in server.py is updated to replace a reference to a deleted Beethoven "Ode to Joy" feedpak with an existing "The Adicts" feedpak entry and its content path. CHANGELOG.md documents this fix under Unreleased.

Changes

Starter content feedpak fix

Layer / File(s) Summary
Update starter feedpak source
server.py, CHANGELOG.md
Replaces the deleted Beethoven Ode to Joy feedpak entry with "The Adicts - ode-to-joy_vst_cover" feedpak (and its content path) in the starter content sources list; changelog documents the fix and references test coverage.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

  • got-feedBack/feedBack#743: Both PRs touch server.py's bundled starter content seeding behavior and update tests/test_builtin_starter_seed.py.
  • got-feedBack/feedBack#744: Both PRs modify _BUILTIN_STARTER_SOURCES and starter seed test coverage for the "Ode to Joy" pack.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes resyncing the starter manifest with the files on disk.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/starter-content-sources

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR re-syncs the server’s built-in starter-pack manifest with the actual content/starter/ files on disk so first-run starter seeding works again (and CI guard tests stop failing).

Changes:

  • Update _BUILTIN_STARTER_SOURCES to remove the deleted beethoven-ode_to_joy.feedpak entry and add the_adicts-ode-to-joy_vst_cover.feedpak.
  • Add a changelog entry documenting the restored starter seeding and the manifest/disk mismatch root cause.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
server.py Updates the starter-pack source manifest to match content/starter/*.feedpak, restoring starter seeding behavior.
CHANGELOG.md Documents the starter seeding fix and the newly-shipped starter pack entry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@byrongamatos
byrongamatos merged commit 2c1c6f7 into main Jul 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants