Uh oh!
There was an error while loading. Please reload this page.
Forward cloud AMICODE_PULSE into the run inspector - #231
Merged
Conversation
Cloud solves surfaced iteration/convergence rows and frames in the run
inspector, but the pulse plot stayed empty: the poll pump forwarded
AMICODE_ITER (/stats) and PNG frames (/frames) into the mirror run.log, but
never the AMICODE_PULSE_META / AMICODE_PULSE lines. The render side (native
type-aware pulse plot) already tails these off run.log for local solves; it
just never received them for cloud runs.
Add a /pulse poll lane that mirrors /stats exactly: relay AMICODE_PULSE_META
once (it carries no iter) and each new AMICODE_PULSE line on the iteration
high-water (the API re-serves history every poll), verbatim so the a= drive
knots AND the d= derivative tail reach the plotter unaltered. Best-effort like
stats/frames: a runner/API without /pulse 404s and is swallowed, so this is
safe to merge before the cloud endpoint exists.
Client-only: does not touch the solve templates / solver output.
Requires a cloud companion: GET /solves/{id}/pulse in the solves_poll lambda,
~10 lines mirroring _stats (grep AMICODE_PULSE* out of the S3-synced run.log,
return {task_id, pulse: [{raw}], submitter}).Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
/pulsepoll lane toRemoteExecutorso a cloud solve's progressive pulse reaches the run inspector — the last missing piece for "submit a cloud solve → watch the pulse animate," which works locally today but not for cloud runs.Why
The poll pump already forwards
AMICODE_ITER(/stats) and PNG frames (/frames) into the mirrorrun.log, but never theAMICODE_PULSE_META/AMICODE_PULSElines. The render side (native type-aware pulse plot, #224) tails these offrun.logfor local solves — it just never received them for cloud runs, so the cloud pulse plot stayed at "No pulse data."How
A
/pulselane that mirrors/statsexactly (remote_executor.ts):AMICODE_PULSE_METAonce (it carries noiter),AMICODE_PULSEline on the iteration high-water (the API re-serves full history each poll),a=drive knots and thed=derivative tail reach the plotter unaltered./pulse404s → swallowed → no-op, so this is safe to merge before the cloud endpoint exists (degrades exactly like the pre-feat(hp): cloud-only enforcement + cloud iters/frames reach the Run Inspector #219 state).Scope
Client-only. Does not touch the solve templates / solver output (@rchari's current lane) — this only relays whatever pulse the solve already emits.
GET /solves/{id}/pulsein thesolves_polllambda (aws-infra), ~10 lines mirroring_stats:Response shape
{task_id, pulse: [{raw}], submitter}— identical to/stats. Until it ships, this lane is inert (no-op), not broken.Tests
FakeCloudnow serves/pulse(mirrors the live wire shape); new test asserts the meta line is relayed once and pulse frames dedupe on the iteration high-water inrun.log. Fullamico-runsuite green (939 passed); build + typecheck + prettier clean.End-to-end status (for context)
This is client gap #1 of the "Altissimo cloud solve → run inspector" flow. Remaining: (2) an Altissimo emitter branch in the solve template (Raghav's #2 — coarse, per-outer-iteration), and (3) an amicode release carrying #219 + #224 + this.