Fix and find typos in hs sources by philderbeast · Pull Request #11501 · haskell/cabal

philderbeast · 2026-02-21T00:52:41Z

A follow on from #10603, check for typos in *.hs and other source files. I didn't change the existing configuration we use for spell checking the docs or the method of supplying *.rst and *.md files but I did change their Makefile recipes to take an explicit --config option, renaming their config file to .typos-docs.yml:

- .typos.yml+ .typos-docs.yml+ .typos-srcs.yml

Adds two Makefile .PHONY targets for finding and fixing typos and a GitHub action for finding these typos. Updated .typos-srcs.yml to accept abbreviations we use and some misspellings.

$ make help
...
hs-fix-typos Fix typos in Haskell source files; .hs, .cabal, etc.
hs-typos Find typos in Haskell source files; .hs, .cabal, etc.
markdown-fix-typos Fix typos in markdown files
markdown-typos Find typos in markdown files
typos-install Install typos-cli for typos target using cargo
users-guide-fix-typos Fix typos in users guide
users-guide-typos Find typos in users guide

I'll squash commits before applying the merge label if this pull request is approved.

Patches conform to the coding conventions.
Any changes that could be relevant to users have been recorded in the changelog.
- Is the change significant? If so, remember to add significance: significant in the changelog file.
The documentation has been updated, if necessary.
Manual QA notes have been included.
Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)

- Configure typos for hs abbreviations and allowed misspellings - Fix typo inherithed - Fix typo succesfully - Fix typo environmnet - Fix typo ther - Add more abbreviations and misspellings - Fix typo uncessary - Fix typo becuase - Fix typo Uknown - Remove false hits from dist-newstyle - Add an hs-fix-typos .PHONY target - Exclude non-existent files - Exclude path dist-newstyle - Do path exclusions one per line - Add make hs-typos to typos workflow - Fix typo ReportUserTargerNonexistantFile - Rename files to all-test-suite.* - Bump typo to v1.43.5 - Use separate config for typos for docs & srcs - Add .typos-hs.toml - Use explicit --config with typos - Fix typo --formar in changelog for haskell#1903 - Rename to .typos-srcs.toml - Trigger ci run on push - Fix typo comparision - Fix typo limt - Fix typo appropiate - Fix typo preprocesser - Fix typo verstion - Fix typo cylical - Fix typo synopsys - Add a changelog entry - Exclude the changelog entry with a typo

philderbeast · 2026-03-05T15:02:39Z

@mergify queue

mergify · 2026-03-05T15:02:45Z

Merge Queue Status

Rule:default

✅ Entered queue — 2026-03-05 15:02 UTC
✅ Checks started · on draft merge queue: embarking master (cbbc2ab) and #11501 together #11582
🚫 Left the queue — 2026-03-05 17:07 UTC · at b4a28ea5cebd9041f23b596af6ede1d39f3e94d1

This pull request spent 2 hours 4 minutes 50 seconds in the queue, including 1 hour 54 minutes 41 seconds running CI.

Required conditions to merge

Reason

The merge conditions cannot be satisfied due to failing checks

Failing checks:

🛑 Validate post job

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

geekosaur · 2026-03-05T17:45:41Z

@Mergifyio queue

mergify · 2026-03-05T17:45:48Z

Merge Queue Status

Rule:default

✅ Entered queue — 2026-03-05 17:45 UTC
✅ Checks started · on draft merge queue: embarking master (cbbc2ab) and #11501 together #11583
🚫 Left the queue — 2026-03-05 19:42 UTC · at b4a28ea5cebd9041f23b596af6ede1d39f3e94d1

This pull request spent 1 hour 56 minutes 58 seconds in the queue, including 1 hour 46 minutes 3 seconds running CI.

Required conditions to merge

Reason

The merge conditions cannot be satisfied due to failing checks

Failing checks:

❌ Validate post job

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

geekosaur · 2026-03-05T20:01:53Z

windows-latest 9.2.8 again. try it later.

geekosaur · 2026-03-06T00:20:50Z

@Mergifyio queue

mergify · 2026-03-06T00:20:55Z

Merge Queue Status

Rule:default

✅ Entered queue — 2026-03-06 00:20 UTC
✅ Checks passed · on draft merge queue: embarking master (7c692a1) and #11501 together #11586
✅ Merged — 2026-03-06 02:16 UTC · at b4a28ea5cebd9041f23b596af6ede1d39f3e94d1

This pull request spent 1 hour 55 minutes 32 seconds in the queue, including 1 hour 45 minutes 8 seconds running CI.

Required conditions to merge

geekosaur · 2026-03-06T00:21:51Z

Should be rebased on top of master by Mergify, which is now skipping windows-9.2.8 until we sort out wtf's going on.

philderbeast force-pushed the typo/hs-sources branch from f464308 to ffffeaaCompare February 21, 2026 00:54

sebright reviewed Feb 21, 2026
View reviewed changes

Comment threadcabal-install-solver/tests/UnitTests/Distribution/Solver/Modular/MessageUtils.hs Outdated

ffaf1 reviewed Feb 21, 2026
View reviewed changes

Comment threadMakefile

philderbeast marked this pull request as draft February 21, 2026 12:21

philderbeast force-pushed the typo/hs-sources branch from ffffeaa to 0737b44Compare February 21, 2026 16:52

philderbeast commented Feb 21, 2026
View reviewed changes

Comment thread.github/workflows/typos.yml

philderbeast marked this pull request as ready for review February 21, 2026 17:04

philderbeast added the attention: needs-review label Feb 21, 2026

geekosaur approved these changes Feb 21, 2026
View reviewed changes

Comment threadrelease-notes/WIP-Cabal-3.12.x.0.md Outdated

philderbeast force-pushed the typo/hs-sources branch 3 times, most recently from 80c1c51 to 3cb752fCompare February 25, 2026 18:16

philderbeast mentioned this pull request Feb 26, 2026
HLint suggestions; mapMaybe, maybe, fromMaybe, fuse */map #11529
Merged
2 tasks

philderbeast force-pushed the typo/hs-sources branch 4 times, most recently from 4c1ceab to 9cc81a9Compare March 1, 2026 18:56

Bodigrim reviewed Mar 2, 2026
View reviewed changes

Comment threadcabal-install/src/Distribution/Client/Errors.hs

philderbeast force-pushed the typo/hs-sources branch 2 times, most recently from 13cbfe0 to cdeacc3Compare March 2, 2026 12:37

philderbeast requested review from Bodigrim and ffaf1 March 2, 2026 14:34

ffaf1 approved these changes Mar 2, 2026
View reviewed changes

philderbeast force-pushed the typo/hs-sources branch from cdeacc3 to ff54088Compare March 2, 2026 14:56

philderbeast added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Mar 2, 2026

philderbeast force-pushed the typo/hs-sources branch from ff54088 to b4a28eaCompare March 3, 2026 12:27

mergifyBot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Mar 3, 2026

mergifyBot added dequeued and removed queued labels Mar 5, 2026

mergifyBot added queued and removed dequeued labels Mar 5, 2026

mergifyBot added a commit that referenced this pull request Mar 5, 2026
Merge of#11501
deac0c7

mergifyBot mentioned this pull request Mar 5, 2026
merge queue: embarking master (cbbc2ab) and #11501 together #11582
Closed
86 tasks

mergifyBot added dequeued and removed queued labels Mar 5, 2026

mergifyBot added queued and removed dequeued labels Mar 5, 2026

mergifyBot added a commit that referenced this pull request Mar 5, 2026
Merge of#11501
ba9abee

mergifyBot mentioned this pull request Mar 5, 2026
merge queue: embarking master (cbbc2ab) and #11501 together #11583
Closed
86 tasks

mergifyBot added dequeued and removed queued labels Mar 5, 2026

mergifyBot added queued and removed dequeued labels Mar 6, 2026

mergifyBot added a commit that referenced this pull request Mar 6, 2026
Merge of#11501
e21bae2

mergifyBot mentioned this pull request Mar 6, 2026
merge queue: embarking master (7c692a1) and #11501 together #11586
Closed
86 tasks

mergifyBot merged commit 863616d into haskell:masterMar 6, 2026
403 checks passed

mergifyBot removed the queued label Mar 6, 2026

This was referenced Mar 10, 2026
Fix typo existant #11602
Merged
Fix typo explitic #11621
Merged

Navigation Menu

Uh oh!

Fix and find typos in hs sources - #11501

Fix and find typos in hs sources#11501
mergify[bot] merged 1 commit into
haskell:masterfrom
cabalism:typo/hs-sources

philderbeast commented Feb 21, 2026•
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

philderbeast commented Mar 5, 2026

Uh oh!

mergifyBot commented Mar 5, 2026•
edited
Loading

Uh oh!

geekosaur commented Mar 5, 2026

Uh oh!

mergifyBot commented Mar 5, 2026•
edited
Loading

Uh oh!

geekosaur commented Mar 5, 2026

Uh oh!

geekosaur commented Mar 6, 2026

Uh oh!

mergifyBot commented Mar 6, 2026•
edited
Loading

Uh oh!

geekosaur commented Mar 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

philderbeast commented Feb 21, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

philderbeast commented Mar 5, 2026

Uh oh!

mergifyBot commented Mar 5, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

geekosaur commented Mar 5, 2026

Uh oh!

mergifyBot commented Mar 5, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

geekosaur commented Mar 5, 2026

Uh oh!

geekosaur commented Mar 6, 2026

Uh oh!

mergifyBot commented Mar 6, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Uh oh!

geekosaur commented Mar 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

philderbeast commented Feb 21, 2026•
edited
Loading

mergifyBot commented Mar 5, 2026•
edited
Loading

mergifyBot commented Mar 5, 2026•
edited
Loading

mergifyBot commented Mar 6, 2026•
edited
Loading