Skip to content

Fix broken link to accessing-data-files - #11516

Merged
mergify[bot] merged 1 commit into
haskell:masterfrom
cabalism:docs/broken-link-accessing-data-files
Mar 2, 2026
Merged

Fix broken link to accessing-data-files#11516
mergify[bot] merged 1 commit into
haskell:masterfrom
cabalism:docs/broken-link-accessing-data-files

Conversation

@philderbeast

@philderbeastphilderbeast commented Feb 24, 2026

Copy link
Copy Markdown
Collaborator

Follow on from #7469. The nitpick -n option did not catch the bad link. The accessing-data-files section label was added in #6971.

When using the :ref:label syntax nitpicking finds a bad link:

$ git diff
...
-Unlike :file:`Paths_{pkgname}` (see :ref:`accessing-data-files`),+Unlike :file:`Paths_{pkgname}` (see :ref:`accessing-data-folies`),
$ make users-guide
...
/.../cabal/doc/cabal-package-description-file.rst:3159:
WARNING: undefined label: 'accessing-data-folies' [ref.ref]
...
make: *** [Makefile:287: users-guide] Error 2

When using the `description <#anchor>`_ syntax nitpicking fails to report the bad link:

...
-Unlike :file:`Paths_{pkgname}` (see `accessing data files <#accessing-data-files-from-package-code>`_),+Unlike :file:`Paths_{pkgname}` (see `accessing data files <#accessing-data-folies-from-package-code>`_),

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@philderbeast
philderbeastforce-pushed the docs/broken-link-accessing-data-files branch from 19d24f7 to 23e1f8bCompareFebruary 25, 2026 12:01
@philderbeastphilderbeast added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Feb 28, 2026
@mergifymergifyBot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels Feb 28, 2026
@mergify

mergifyBot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

Rule:default


This pull request spent 1 hour 28 minutes 51 seconds in the queue, including 1 hour 16 minutes 44 seconds running CI.

Required conditions to merge
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Validate post job
    • check-skipped = Validate post job
    • check-success = Validate post job
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

Reason

The merge conditions cannot be satisfied due to failing checks

Failing checks:

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

mergifyBot added a commit that referenced this pull request Mar 2, 2026
@mergifymergifyBot added dequeued and removed queued labels Mar 2, 2026
@philderbeast

Copy link
Copy Markdown
CollaboratorAuthor

@Mergifyio queue

@mergify

mergifyBot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

Rule:default


This pull request spent 4 hours 19 minutes 44 seconds in the queue, including 1 hour 55 minutes 24 seconds running CI.

Required conditions to merge
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

@mergifymergifyBot added queued and removed dequeued labels Mar 2, 2026
mergifyBot added a commit that referenced this pull request Mar 2, 2026
mergifyBot added a commit that referenced this pull request Mar 2, 2026
@mergify
mergifyBot merged commit 575a694 into haskell:masterMar 2, 2026
290 checks passed
@mergifymergifyBot removed the queued label Mar 2, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge delay passedApplied (usually by Mergify) when PR approved and received no updates for 2 daysmerge meTell Mergify Bot to mergeready and waitingMergify is waiting out the cooldown period

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@philderbeast@geekosaur@ffaf1