Skip to content

Add HLint hint to use findWithDefault - #11535

Merged
mergify[bot] merged 1 commit into
haskell:masterfrom
cabalism:hlint-rule/hint-use-findWithDefault
Mar 3, 2026
Merged

Add HLint hint to use findWithDefault#11535
mergify[bot] merged 1 commit into
haskell:masterfrom
cabalism:hlint-rule/hint-use-findWithDefault

Conversation

@philderbeast

@philderbeastphilderbeast commented Feb 27, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

Fixes#11534.

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@philderbeast
philderbeastforce-pushed the hlint-rule/hint-use-findWithDefault branch from f77a102 to 52b11a8CompareFebruary 27, 2026 20:31
@philderbeastphilderbeast mentioned this pull request Feb 27, 2026
Merged
2 tasks
@philderbeastphilderbeast added the merge me Tell Mergify Bot to merge label Feb 27, 2026
@philderbeast
Add cabal group with hint for findWithDefault
6af7d49
- Follow cabal suggestion: use findWithDefault
@philderbeast
philderbeastforce-pushed the hlint-rule/hint-use-findWithDefault branch from 52b11a8 to 6af7d49CompareFebruary 27, 2026 21:13
@mergifymergifyBot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days queued labels Feb 28, 2026
@mergify

mergifyBot commented Mar 2, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

Rule:default

This pull request spent 18 minutes 46 seconds in the queue, including 6 minutes 55 seconds running CI.

Required conditions to merge
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
    • check-success = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Meta checks
    • check-skipped = Meta checks
    • check-success = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Validate post job
    • check-skipped = Validate post job
    • check-success = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
    • check-success = Bootstrap post job
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

Reason

The merge conditions cannot be satisfied due to failing checks

Failing checks:

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

mergifyBot added a commit that referenced this pull request Mar 2, 2026
@mergify
Merge of#11535
76a9cf6
This was referenced Mar 2, 2026
Closed
Merged
mergifyBot added a commit that referenced this pull request Mar 2, 2026
@mergify
Merge of#11535
87d126c
@mergifymergifyBot mentioned this pull request Mar 2, 2026
Closed
86 tasks
@mergifymergifyBot added dequeued and removed queued labels Mar 2, 2026
@geekosaur

geekosaur commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator

@Mergifyio queue

@mergify

mergifyBot commented Mar 2, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

Rule:default

This pull request spent 1 hour 46 minutes 31 seconds in the queue, including 1 hour 36 minutes 9 seconds running CI.

Required conditions to merge
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Validate post job
    • check-skipped = Validate post job
    • check-success = Validate post job
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

Reason

The merge conditions cannot be satisfied due to failing checks

Failing checks:

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

@mergifymergifyBot added queued and removed dequeued labels Mar 2, 2026
mergifyBot added a commit that referenced this pull request Mar 2, 2026
@mergify
Merge of#11535
308cb9c
@mergifymergifyBot mentioned this pull request Mar 2, 2026
Closed
92 tasks
mergifyBot added a commit that referenced this pull request Mar 2, 2026
@mergify
Merge of#11535
be9116d
@mergifymergifyBot mentioned this pull request Mar 2, 2026
Closed
86 tasks
@mergifymergifyBot added dequeued and removed queued labels Mar 2, 2026
@philderbeast

philderbeast commented Mar 2, 2026

Copy link
Copy Markdown
CollaboratorAuthor

@Mergifyio queue

@mergify

mergifyBot commented Mar 2, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

Rule:default

This pull request spent 2 hours 27 minutes 35 seconds in the queue, including 2 hours 16 minutes 53 seconds running CI.

Required conditions to merge
  • any of [🛡 GitHub branch protection]:
    • check-neutral = Validate post job
    • check-skipped = Validate post job
    • check-success = Validate post job
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

Reason

The merge conditions cannot be satisfied due to failing checks

Failing checks:

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

@mergifymergifyBot added queued and removed dequeued labels Mar 2, 2026
mergifyBot added a commit that referenced this pull request Mar 2, 2026
@mergify
Merge of#11535
8dfbf38
This was referenced Mar 2, 2026
Closed
Merged
mergifyBot added a commit that referenced this pull request Mar 2, 2026
@mergify
Merge of#11535
0cbda98
@mergifymergifyBot mentioned this pull request Mar 2, 2026
Closed
86 tasks
@mergifymergifyBot added dequeued and removed queued labels Mar 2, 2026
@geekosaur

geekosaur commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator

@Mergifyio queue

@mergify

mergifyBot commented Mar 2, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

Rule:default

This pull request spent 1 hour 57 minutes 27 seconds in the queue, including 1 hour 46 minutes 57 seconds running CI.

Required conditions to merge
  • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = Doctest Cabal
    • check-neutral = Doctest Cabal
    • check-skipped = Doctest Cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Meta checks
    • check-neutral = Meta checks
    • check-skipped = Meta checks
  • any of [🛡 GitHub branch protection]:
    • check-success = docs/readthedocs.org:cabal
    • check-neutral = docs/readthedocs.org:cabal
    • check-skipped = docs/readthedocs.org:cabal
  • any of [🛡 GitHub branch protection]:
    • check-success = Validate post job
    • check-neutral = Validate post job
    • check-skipped = Validate post job
  • any of [🛡 GitHub branch protection]:
    • check-success = fourmolu
    • check-neutral = fourmolu
    • check-skipped = fourmolu
  • any of [🛡 GitHub branch protection]:
    • check-success = hlint
    • check-neutral = hlint
    • check-skipped = hlint
  • any of [🛡 GitHub branch protection]:
    • check-success = Bootstrap post job
    • check-neutral = Bootstrap post job
    • check-skipped = Bootstrap post job
  • any of [🛡 GitHub branch protection]:
    • check-success = whitespace
    • check-neutral = whitespace
    • check-skipped = whitespace
  • any of [🛡 GitHub branch protection]:
    • check-success = Check sdist post job
    • check-neutral = Check sdist post job
    • check-skipped = Check sdist post job
  • any of [🛡 GitHub branch protection]:
    • check-success = Changelogs
    • check-neutral = Changelogs
    • check-skipped = Changelogs

@mergifymergifyBot added queued and removed dequeued labels Mar 2, 2026
mergifyBot added a commit that referenced this pull request Mar 2, 2026
@mergify
Merge of#11535
e0bec28
@mergifymergifyBot mentioned this pull request Mar 2, 2026
Closed
86 tasks
@mergify
mergifyBot merged commit d67898a into haskell:masterMar 3, 2026
430 of 433 checks passed
@mergifymergifyBot removed the queued label Mar 3, 2026
@geekosaur

geekosaur commented Mar 3, 2026

Copy link
Copy Markdown
Collaborator

About ****ed time….

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geekosaurgeekosaurgeekosaur approved these changes
@ffaf1ffaf1ffaf1 approved these changes

Assignees

No one assigned

Labels

merge delay passedApplied (usually by Mergify) when PR approved and received no updates for 2 daysmerge meTell Mergify Bot to mergeready and waitingMergify is waiting out the cooldown period

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Could we use Map.findWithDefault?

3 participants

@philderbeast@geekosaur@ffaf1