fix: address clang-tidy 17 errors

[isidorowiczdev]

CI enables clang-tidy with -warnings-as-errors, and three checks
were failing the build:

• clang-analyzer-cplusplus.NewDeleteLeaks (24+ sites across
  TokenEndpointImpl, IndexLayerClientImpl, VolatileLayerClientImpl,
  VersionedLayerClientImpl, StreamLayerClientImpl): Every flagged
  call path was traced end-to-end and contains zero raw new/delete;
  ownership is shared_ptr/std::function throughout, so each site
  is suppressed with NOLINTNEXTLINE

• clang-analyzer-deadcode.DeadStores (Crypto.cpp:171): ComputeSha256
  mutated value via >>= when packing the last output byte, a
  redundant shift whose result was never read; changed to
  non-mutating >>.

• clang-analyzer-optin.cplusplus.VirtualCall (SignInResultImpl.cpp:95):
  the constructor called virtual IsValid() instead of reading
  is_valid_ directly

Resolves: DATASDK-104

Signed-off-by: Iwo Sidorowicz iwo.sidorowicz@here.com
Co-Author: Yaroslav Stefinko ext-yaroslav.stefinko@here.com

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.39%. Comparing base (6363d4f) to head (6cb994d).

Additional details and impacted files

@@ Coverage Diff @@## master #1723 +/- ##
==========================================
+ Coverage 80.34% 80.39% +0.05% 
==========================================
Files 356 356 Lines 14295 14294 -1 Branches 1565 1566 +1 ==========================================
+ Hits 11485 11491 +6 + Misses 2178 2174 -4 + Partials 632 629 -3 

Files with missing lines	Coverage Δ
olp-cpp-sdk-authentication/src/Crypto.cpp	87.85% <100.00%> (ø)
...lp-cpp-sdk-authentication/src/SignInResultImpl.cpp	95.08% <100.00%> (ø)
...p-cpp-sdk-authentication/src/TokenEndpointImpl.cpp	84.09% <ø> (ø)
...sdk-dataservice-write/src/IndexLayerClientImpl.cpp	69.61% <ø> (ø)
...dk-dataservice-write/src/StreamLayerClientImpl.cpp	85.59% <ø> (ø)
...dataservice-write/src/VersionedLayerClientImpl.cpp	39.36% <ø> (ø)
...-dataservice-write/src/VolatileLayerClientImpl.cpp	12.25% <ø> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[rustam-gamidov-here]

No issues found, Except that i would simplify MR title a bit as 'fix' and 'address' looks pretty similar and to follow previous MRs style