Skip to content

fix(local): isolate workspace --name from Dory --dory-name - #90

Merged
patrickleet merged 1 commit into
feat/local-workbench-epicfrom
fix/workbench-preserve-shared-identity-ns
Aug 12, 2026
Merged

patrickleet merged 1 commit into
feat/local-workbench-epicfrom
fix/workbench-preserve-shared-identity-ns

Conversation

@patrickleet

Copy link
Copy Markdown
Collaborator

Summary

  • Rename global Dory desktop flag to --dory-name so hops local up --name alice no longer rewrites kube/docker context
  • Reconcile stamps worktree namespace only on app workloads (Deployment/Service/Oidc/Features); shared Project/Role/Human keep chart namespaces
  • Unit tests for namespace policy dual isolation and clap flag separation

Stack

Stacked on feat/local-workbench-epic (#89).

Test plan

  • cargo test --bin hops-cli workspace_name_does_not_set_dory_name
  • cargo test --bin hops-cli ensure_namespace
  • Local dual-worktree suite against Dory (see distributed PR)

Preserve chart namespaces for shared identity MRs while stamping only
app workloads; rename the global Dory flag so dual workspaces cannot
rewrite the desktop kube/docker context.
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3c35f27b-c622-478a-90ad-4e73c0168811

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patrickleet

Copy link
Copy Markdown
Collaborator Author

Companion distributed suite PR: hops-ops/distributed#178

@patrickleet

Copy link
Copy Markdown
Collaborator Author

Productionization started for pinned head 7a3eba1ffd2685b4e60cd048b7dc9dcb75a951b5. I will review the complete diff, apply and validate any required fixes within the bounded workflow, run the configured proof gate, and publish the final result. The pull request will remain open.

@patrickleet

Copy link
Copy Markdown
Collaborator Author

Review pass 1: dirty.

Finding F1 (blocking): the pinned head passes all 194 Rust tests, but the PR is DIRTY/unmergeable after feat/local-workbench-epic advanced. The base now includes safer per-document YAML parsing and applies manifests with kubectl --namespace, which preserves explicit shared-resource namespaces while defaulting namespace-less workloads. The branch must integrate the current base, retain the distinct --dory-name behavior, and resolve the overlapping reconcile changes without regressing those base fixes.

Validation on pinned head: cargo test passed (187 unit + 7 integration tests).

@patrickleet

Copy link
Copy Markdown
Collaborator Author

Productionization run started for pinned head 7a3eba1ffd2685b4e60cd048b7dc9dcb75a951b5. I will review the complete change, apply and validate any required fix, run the configured proof gate, and leave this pull request open.

@patrickleet

Copy link
Copy Markdown
Collaborator Author

Review pass 1 — changes required

  • The pinned head predates the current target branch and does not merge cleanly: src/commands/local/mod.rs conflicts over the global Dory name field, while src/commands/local/workbench/reconcile.rs conflicts with the target branch namespace-application redesign. The fix must retain the PR’s distinct --dory-name, adopt the target branch’s kubectl apply --namespace behavior (which preserves explicitly namespaced shared identity resources without a kind allowlist), and retain regression coverage.

Validation on the pinned head: cargo test passed (194 tests total). cargo fmt --all -- --check reports repository-wide pre-existing formatting drift, including files outside this PR; no formatting-only expansion is planned.

@patrickleet
patrickleet merged commit 4b7cee9 into main Aug 12, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant