fix: productionize local workbench stack

[patrickleet]

Summary

• collect the productionize findings above the existing native PR stack
• preserve the cluster/worktree GitOps command model and cluster/docker provider split
• harden manifest parsing, retries, DNS state, privileged file handling, process ownership, and workspace pruning
• keep hops local up absent

Verification

• cargo fmt --check
• cargo test -p hops-cli — 211 unit tests and 7 smoke tests passed

Stack

This PR is based on #93 and intentionally leaves #89, #90, #92, and #93 in their existing native GitHub stack order.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: dbf81a10-1a3f-496b-aa17-fe8961101bf7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[patrickleet]

Productionization review started for pinned head 8f6537ba8e800408ae3d3d0b0f1c75e15d38bd95. The workflow will review, apply any bounded fixes, run the configured proof gate, and leave this pull request open.

[patrickleet]

Review pass 1 found one functional issue on pinned head 8f6537ba8e800408ae3d3d0b0f1c75e15d38bd95: DNS runtime files use canonical workspace slugs, but the current-workspace exclusion compared the raw display name. Restarting a workspace such as My Workspace after a service was removed could merge its stale runtime entry back into /etc/hosts and the DNS zone. The bounded fix normalizes the comparison, adds a regression test, removes an uncalled apply helper, and makes lock-file non-truncation explicit.

[patrickleet]

Productionization run 2 started on pinned head .

I’ll review the complete PR, apply and validate any bounded fixes, re-review if needed, run the configured proof gate, and leave this PR open.

[patrickleet]

Review pass 1: clean on pinned head b194274dd4b64603b6b217e487ec53b4c07f13b3.

Validated the complete PR diff, DNS/process/runtime lifecycle changes, YAML handling, kube-context propagation, documentation, and smoke workflow.

Checks:

• cargo fmt --all -- --check
• cargo test --all-targets (219 tests passed)
• cargo clippy --all-targets (completed; existing warnings only)
• git diff --check
• GitHub kind-smoke and quality checks passed

No unresolved findings.

[patrickleet]

Productionization completed successfully on unchanged pinned head b194274dd4b64603b6b217e487ec53b4c07f13b3.

• Complete review: clean (pass 1)
• Local validation: formatting, 219 tests, Clippy, and diff checks completed
• PR checks: kind-smoke and quality passed; platform-specific optional jobs skipped as configured
• Repository proof adapter: not configured; proof is optional
• Fix passes in this run: 0
• Unresolved findings/blockers: 0

The pull request remains open and was not merged, approved, closed, or configured for auto-merge.